Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profile version test #1383

Merged

Conversation

bernt-matthias
Copy link
Contributor

linter has been adapted to new style profile versions and got a bit more relaxed.

galaxyproject/galaxy#16480

Alternatively we could work on the linter in Galaxy, e.g. something along:

try:
    profile_year, profile_month =  profile.split(".")
except Exception:
    handle_error
if int(profile_year) < 10:
    handle_error
if int(profile_year) < 23:
    if not profile_month in ["01", "02", "03", "04", ... ]:
        handle_error
else:
    if not re.match(profile_month, r"\d"):
        handle_error

linter has been adapted to new style profile versions
and got a bit more relaxed.

galaxyproject/galaxy#16480
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bernt-matthias bernt-matthias merged commit 8795cac into galaxyproject:master Aug 23, 2023
14 checks passed
@bernt-matthias bernt-matthias deleted the topic/fix-profile-test branch August 23, 2023 09:39
@mvdbeek mvdbeek changed the title fix profile version test Fix profile version test Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants