New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cwltool and galaxy-lib dependencies for Python 3.7 #864

Merged
merged 1 commit into from Sep 13, 2018

Conversation

Projects
None yet
2 participants
@nsoranzo
Copy link
Member

nsoranzo commented Aug 31, 2018

Fix #863 .

Need a release which includes common-workflow-language/cwltool#831 .

@nsoranzo nsoranzo added bug cwl labels Aug 31, 2018

@nsoranzo

This comment has been minimized.

Copy link
Member Author

nsoranzo commented Aug 31, 2018

The 4 failing tests will be fixed by galaxyproject/galaxy-lib#129 , a new galaxy-lib release and a corresponding update to requirements.txt.

@nsoranzo nsoranzo force-pushed the nsoranzo:update_cwltool_dep branch from 4fe55b8 to bad810a Sep 12, 2018

@nsoranzo nsoranzo changed the title Update cwltool dependencies for Python 3.7 Update cwltool and galaxy-lib dependencies for Python 3.7 Sep 12, 2018

@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Sep 12, 2018

I worried about this - cwltool underwent significant API breaking changes. I'll try to find some time to sit down and see if I can work through them.

@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Sep 12, 2018

I'm going to cherry-pick bad810a into master though - I hope that is okay.

@nsoranzo

This comment has been minimized.

Copy link
Member Author

nsoranzo commented Sep 12, 2018

Go ahead with the cherry-pick!

@nsoranzo nsoranzo force-pushed the nsoranzo:update_cwltool_dep branch from bad810a to 9250c2b Sep 13, 2018

@jmchilton jmchilton merged commit 393aeb2 into galaxyproject:master Sep 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nsoranzo nsoranzo deleted the nsoranzo:update_cwltool_dep branch Sep 13, 2018

jmchilton added a commit that referenced this pull request Sep 14, 2018

Rev toil for testing - still broken from #864.
Need a release of Toil with DataBiosphere/toil#2341 which isn't in any release yet I don't think.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment