Skip to content

Commit

Permalink
Drop continue-on-error for tests that should pass now
Browse files Browse the repository at this point in the history
  • Loading branch information
mvdbeek committed Apr 8, 2023
1 parent b953b30 commit 7493cbe
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion .github/workflows/galaxy_framework.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,21 @@ jobs:
with:
path: ~/.cache/pip
key: pip-cache-${{ matrix.python-version }}-${{ hashFiles('galaxy/requirements.txt') }}
- name: Run tests
- name: Run tests (and allow failure)
run: ./run_tests.sh --framework
if: matrix.galaxy-branch != 'pulsar_standing_branch'
working-directory: 'galaxy'
env:
GALAXY_TEST_JOB_CONFIG_FILE: ../pulsar/test_data/test_job_conf.yaml
GALAXY_CONFIG_OVERRIDE_METADATA_STRATEGY: ${{ matrix.metadata-strategy }}
continue-on-error: true
- name: Run tests (must pass)
if: matrix.metadata-strategy == 'directory' && matrix.galaxy-branch == 'pulsar_standing_branch'
run: ./run_tests.sh --framework
working-directory: 'galaxy'
env:
GALAXY_TEST_JOB_CONFIG_FILE: ../pulsar/test_data/test_job_conf.yaml
GALAXY_CONFIG_OVERRIDE_METADATA_STRATEGY: ${{ matrix.metadata-strategy }}
- uses: actions/upload-artifact@v2
with:
name: Framework test results (${{ matrix.python-version }})
Expand Down

0 comments on commit 7493cbe

Please sign in to comment.