Use managers defined in job destination parameters #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If manager name was specified in the destination parameters, include the managers/<manager_name> route in the url.
| manager = destination_params.get("manager", None) | ||
| if manager: | ||
| remote_host = urljoin(remote_host, "managers/%s" % manager) | ||
| if not remote_host.endswith("/"): |
There was a problem hiding this comment.
For backward compatibility can you check if the URL contains managers/ already and warn the user the supplied manager will be ignored?
and log a warning.
|
Perfect - this makes a lot of sense. Thanks a bunch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way there is no discrepancy between the arguments that message queue pulsar and http pulsar consume.