Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration parameter to limit stream size read from disk. #157

Merged
merged 1 commit into from Feb 14, 2018

Conversation

jmchilton
Copy link
Member

Set with maximum_stream_size in app.yml.

Default to 1MB.

Fixes underlying problem in #151 I think, though doesn't actually do what was requested. I prefer this - is that okay @natefoo?

Set with maximum_stream_size in app.yml.

Default to 1MB.

Fixes underlying problem in galaxyproject#151 I think, though doesn't actually do what was requested. I prefer this - is that okay @natefoo?
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 82.431% when pulling b4b4aa2 on jmchilton:output_limit into afd5886 on galaxyproject:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 82.431% when pulling b4b4aa2 on jmchilton:output_limit into afd5886 on galaxyproject:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 82.431% when pulling b4b4aa2 on jmchilton:output_limit into afd5886 on galaxyproject:master.

@jmchilton jmchilton added this to WIP in usegalaxy.org Feb 14, 2018
@natefoo
Copy link
Member

natefoo commented Feb 14, 2018

It'd be nice if we could avoid losing the stdout/stderr as the error message you'd use to determine why a job failed is likely at the end. But this will at least avoid the biggest problem, which is RabbitMQ crashing on huge messages.

@jmchilton jmchilton merged commit 4e3ee58 into galaxyproject:master Feb 14, 2018
@jmchilton
Copy link
Member Author

It'd be nice if we could avoid losing the stdout/stderr as the error message you'd use to determine why a job failed is likely at the end.

Agreed.

And another next step that would be nice from an API perspective is to avoid the concatenation that Galaxy does. I'd rather have structured information - like {..., "stdout_contents": "...", "stdout_truncated": true, "stdout_contents_end": "..."} in this API and then let Galaxy mangle the data I think.

@natefoo
Copy link
Member

natefoo commented Feb 15, 2018

What's the concatenation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
usegalaxy.org
Committed
Development

Successfully merging this pull request may close these issues.

None yet

3 participants