Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to merge Pulsar Docker images (1 / ...) #195

Merged
merged 3 commits into from Jun 21, 2019

Conversation

jmchilton
Copy link
Member

@jmchilton jmchilton commented Jun 18, 2019

I was working on getting the Kubernetes support to just work with a single container and container resolution (after being prodded to do this by @nuwang). I got it working with Conda environments inside the container - but obviously being able to leverage Conda from CVMFS would be beneficial as would being able to leverage reference data from my Kubernetes work. So I'm trying to merge the differences between our containers down. If they need to be different - hopefully one can just depend on the other or they can both depend on some common base container. To make sharing files easier I'm trying to move scripts and data used into pulsar.scripts - so installing Pulsar results in this stuff being available and being self contained (no need to ensure things are below the Dockerfile base path, etc..).

@coveralls
Copy link

coveralls commented Jun 18, 2019

Coverage Status

Coverage decreased (-0.07%) to 80.918% when pulling a050c41 on jmchilton:merge_pulsar_docker_images into 4a13e05 on galaxyproject:master.

@jmchilton jmchilton changed the title [WIP] Attempt to merge Pulsar Docker images. Attempt to merge Pulsar Docker images (1 / ...) Jun 21, 2019
@jmchilton
Copy link
Member Author

Merging because there is an important fix in here - the cvmfs Docker image still doesn't build because of #166 (comment)

@jmchilton jmchilton merged commit 2869294 into galaxyproject:master Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants