Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test and mypy fixes. Add support for Python 3.11 #312

Merged
merged 4 commits into from Apr 12, 2023
Merged

Test and mypy fixes. Add support for Python 3.11 #312

merged 4 commits into from Apr 12, 2023

Conversation

nsoranzo
Copy link
Member

Planemo tests still fail on the py37-install_wheel build, but I don't know enough about those to fix it.

I think these are still good fixes and could probably be merged nonetheless?

@jmchilton
Copy link
Member

  • I would like to continue to support Python 3.6 - until it is blocking something important.
  • Are pycurl tests not running that ran before - I'm confused by that line.

@nsoranzo
Copy link
Member Author

  • I would like to continue to support Python 3.6 - until it is blocking something important.

For that you'd need to either change runs-on: to ubuntu-20.04 for all tests or use an ad-hoc way to install Python 3.6 on ubuntu-latest (i.e. 22.04) since actions/setup-python doesn't support it there.

* Are pycurl tests not running that ran before - I'm confused by that line.

That line is redundant since pycurl is later installed by tox (test,install_wheel,mypy: -rdev-requirements.txt) and the package has a different name (python3-pycurl) in Ubuntu 22.04.

jmchilton added a commit that referenced this pull request Feb 8, 2023
@jmchilton
Try to fix CI.
ea27f89 
Taking advice from Nicola in #312.
@nsoranzo
Copy link
Member Author

nsoranzo commented Feb 9, 2023

Should I try to rebase this, given the conflicts generated by #315, or just close it?

@jmchilton
Copy link
Member

Doh - sorry. I assumed you had given up on the PR because I wanted to support 3.6. If you'd like to rebase that would be wonderful, but I made the mess and I'd be happy to pull out the 3.11 support and the tox refactorings and apply them in isolation.

@jmchilton jmchilton mentioned this pull request Feb 9, 2023
Merged
@nsoranzo
Copy link
Member Author

nsoranzo commented Feb 9, 2023

I can rebase, hopefully in the next days, no worries.

@nsoranzo nsoranzo force-pushed the tox_fixes branch 4 times, most recently from bdb3cee to fb80358 Compare February 10, 2023 11:24
@nsoranzo
Copy link
Member Author

Rebased and ready for re-review.

@mvdbeek
Copy link
Member

mvdbeek commented Apr 12, 2023

Is the latest kombu not being compatible with python 3.6 a good enough reason to drop it ? (https://github.com/galaxyproject/pulsar/actions/runs/4678097934/jobs/8286413656?pr=323). That kombu version seems to have some important timeout handling fixes (https://github.com/celery/kombu/releases/tag/v5.2.3)

@nsoranzo nsoranzo changed the title Test and mypy fixes. Drop support of Python 3.6, add support for 3.11 Test and mypy fixes. Add support for 3.11 Apr 12, 2023
@nsoranzo
Copy link
Member Author

BTW, the PR title had become misleading (fixed now), this is not removing Python 3.6 support any more given @jmchilton's concerns (I am still obviously in favour of dropping it).

@nsoranzo
Fix tox environment names
64c0074 
- Don't use hyphens in the middle of an environment name, they are used
  to split them in factors.
- Simplify
@nsoranzo
Mypy fixes
743ea92
@nsoranzo
Add support for Python 3.11
bd62da1 
Test on Python 3.6 and 3.11 without all intermediate versions.

Also:
- Remove install of `python-pycurl` in GitHub workflow, `pycurl` is installed
  later via tox without having to keep track of Ubuntu package name changes.
@nsoranzo
Restore minimum version requirements
63103a3 
Lost in galaxyproject#315 .
@jmchilton
Copy link
Member

It feels like Pulsar has a lot of modalities that won't require that kombu fix so I'm in favor of continuing to support Python 3.6. The whole purpose of Pulsar originally was allowing the execution of Galaxy jobs in places Galaxy couldn't run - I'm not eager to remove environments.

@nsoranzo nsoranzo merged commit f02b31d into galaxyproject:master Apr 12, 2023
12 of 14 checks passed
@nsoranzo nsoranzo deleted the tox_fixes branch April 12, 2023 18:09
@nsoranzo nsoranzo changed the title Test and mypy fixes. Add support for 3.11 Test and mypy fixes. Add support for Python 3.11 Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmchilton jmchilton jmchilton approved these changes

@mvdbeek mvdbeek mvdbeek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nsoranzo @jmchilton @mvdbeek