User auth plugins #321
Merged
User auth plugins #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me, besides the conflict that needs resolving I think my only comment is that it would be nice to have a small example of a configuration in the docs and how to verify it works. |
as job launch parameter so that it is sent to Pulsar from Galaxy. See corresponding PR (galaxyproject/galaxy#15300) and issue (galaxyproject/galaxy#15526) for Galaxy
Includes methods to authenticate based on OIDC token (see issue galaxyproject/galaxy#15526)
SergeyYakubov
force-pushed
the
user-auth-plugins
branch
from
f2d42ac
to
56faf45
Compare
|
I think you need to add pulsar.user_auth to https://github.com/galaxyproject/pulsar/blob/master/setup.py#L57 (or use |
SergeyYakubov
force-pushed
the
user-auth-plugins
branch
from
0cac03c
to
8fe2942
Compare
Closed
|
Thanks so much @SergeyYakubov, I'm sure we'll get the corresponding galaxy part in before the next release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to configure plugins for user authentication/authorization. Includes methods to authenticate based on OIDC token (see issue galaxyproject/galaxy#15526).
This is a stacked PR after #320