Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add catchall OSError to recoverable exceptions #338

Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Sep 14, 2023

I'd love if this wasn't so broad, but fixes

Sep 14 02:50:25 jetstream2.galaxyproject.org pulsar[3746252]: 2023-09-14 02:50:25,143 ERROR [pulsar.client.amqp_exchange][consume-setup-amqp://main_pulsar:********@amqp.galaxyproject.org:5671//main_pulsar?ssl=1] Problem consuming queue, consumer quitting in problematic fashion!
Sep 14 02:50:25 jetstream2.galaxyproject.org pulsar[3746252]: Traceback (most recent call last):
Sep 14 02:50:25 jetstream2.galaxyproject.org pulsar[3746252]:   File "/srv/pulsar/main/venv/lib64/python3.9/site-packages/pulsar/client/amqp_exchange.py", line 143, in consume
Sep 14 02:50:25 jetstream2.galaxyproject.org pulsar[3746252]:     connection.drain_events(timeout=self.__timeout)
Sep 14 02:50:25 jetstream2.galaxyproject.org pulsar[3746252]:   File "/srv/pulsar/main/venv/lib64/python3.9/site-packages/kombu/connection.py", line 316, in drain_events
Sep 14 02:50:25 jetstream2.galaxyproject.org pulsar[3746252]:     return self.transport.drain_events(self.connection, **kwargs)
Sep 14 02:50:25 jetstream2.galaxyproject.org pulsar[3746252]:   File "/srv/pulsar/main/venv/lib64/python3.9/site-packages/kombu/transport/pyamqp.py", line 169, in drain_events
Sep 14 02:50:25 jetstream2.galaxyproject.org pulsar[3746252]:     return connection.drain_events(**kwargs)
Sep 14 02:50:25 jetstream2.galaxyproject.org pulsar[3746252]:   File "/srv/pulsar/main/venv/lib64/python3.9/site-packages/amqp/connection.py", line 525, in drain_events
Sep 14 02:50:25 jetstream2.galaxyproject.org pulsar[3746252]:     while not self.blocking_read(timeout):
Sep 14 02:50:25 jetstream2.galaxyproject.org pulsar[3746252]:   File "/srv/pulsar/main/venv/lib64/python3.9/site-packages/amqp/connection.py", line 530, in blocking_read
Sep 14 02:50:25 jetstream2.galaxyproject.org pulsar[3746252]:     frame = self.transport.read_frame()
Sep 14 02:50:25 jetstream2.galaxyproject.org pulsar[3746252]:   File "/srv/pulsar/main/venv/lib64/python3.9/site-packages/amqp/transport.py", line 294, in read_frame
Sep 14 02:50:25 jetstream2.galaxyproject.org pulsar[3746252]:     frame_header = read(7, True)
Sep 14 02:50:25 jetstream2.galaxyproject.org pulsar[3746252]:   File "/srv/pulsar/main/venv/lib64/python3.9/site-packages/amqp/transport.py", line 582, in _read
Sep 14 02:50:25 jetstream2.galaxyproject.org pulsar[3746252]:     raise OSError('Server unexpectedly closed connection')
Sep 14 02:50:25 jetstream2.galaxyproject.org pulsar[3746252]: OSError: Server unexpectedly closed connection

@mvdbeek mvdbeek force-pushed the add_catchall_oserror_to_recoverable branch from 78fa1aa to 856002d Compare September 14, 2023 17:51
@natefoo
Copy link
Member

natefoo commented Sep 14, 2023

Edging ever closer to a bare except: 😄

@mvdbeek mvdbeek merged commit 73c87d6 into galaxyproject:master Sep 15, 2023
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants