Don't use a Python script in sam_pileup #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
added a commit
to mvdbeek/galaxy
that referenced
this pull request
Feb 5, 2020
nsoranzo
reviewed
Feb 5, 2020
nsoranzo
reviewed
Feb 5, 2020
Co-Authored-By: Nicola Soranzo <nicola.soranzo@gmail.com>
|
After spending sometime cleaning up the overlong Python code, I realised this doesn't need to use a Python script at all... I'll work on that later or tomorrow. |
|
It's probably not worth investing too much time though, noone should be using pileup format in 2020 anyway. |
|
@mvdbeek I got rid of the Python, can you double check the changes? |
|
Looks good, thanks @nsoranzo ! |
nsoranzo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.