Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for or in workflow query #4494

Closed
paulzierep opened this issue Nov 8, 2023 · 6 comments · Fixed by #4520
Closed

Allow for or in workflow query #4494

paulzierep opened this issue Nov 8, 2023 · 6 comments · Fixed by #4520

Comments

@paulzierep
Copy link
Collaborator

The GTN hosted workflow query like: https://training.galaxyproject.org/training-material/workflows/embed.html?query=microbiome is useful to select dedicated workflows for a community, would it be possible to add or as an option to fine grain the query possibilities, similar to e.g. query=microbiome+longreads.

@hexylena
Copy link
Member

hexylena commented Nov 8, 2023

We'll look into this! Do you envision needing and support as well? because I'm guessing longreads might return a lot of non-microbiome results.

@paulzierep
Copy link
Collaborator Author

paulzierep commented Nov 8, 2023

isn't my example an and query ?

@hexylena
Copy link
Member

hexylena commented Nov 8, 2023

Ok, then I'm hearing that we need both. We'll have to see what we can do in terms of syntax!

@paulzierep
Copy link
Collaborator Author

As I understand it and does already work, try e.g. https://training.galaxyproject.org/training-material/workflows/embed.html?query=microbiome+nanopore

@hexylena
Copy link
Member

hexylena commented Nov 8, 2023

It definitely wasn't explicitly implemented 😅 hence my confusion. microbiome+nanopore is interpreted as microbiome nanopore (since + is treated as space), it's a complete accident that you're seeing any useful results, because we've put together a couple different fields including tags, which we do a simple text index match against (i.e. no fuzzy query, terms aren't treated separately, etc.)

I'm guessing you'd find more results if it was doing a proper and so, ok, we'll implement both.

@paulzierep
Copy link
Collaborator Author

ah ok, now both our confusion finds an end :) in this case both an and and or would be nice to have

hexylena added a commit that referenced this issue Nov 15, 2023
Fixes #4494

This does not implement a proper query language which would be more
expensive to execute, instead we supply a simpler set of filters:

- all: must include all of these terms
- any: includes at least one of these terms
- none: reject anything with these terms.

E.g. `?all=single-cell&any=mehmet+wendi` would find workflows either by
@nomadscientist or @mtekman.

Again this doesn't implement a query language that supports arbitrarily
complex queries, we keep it simple.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants