Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metaQuantome tutorial: part I #2039

Merged
merged 86 commits into from
Oct 16, 2020
Merged

Conversation

subinamehta
Copy link
Contributor

This tutorial is for uses who want to create datasets that are compatible with the metaQuantome tool. Second part will follow soon.

@subinamehta
Copy link
Contributor Author

subinamehta commented Oct 15, 2020 via email

@malloryfreeberg
Copy link
Collaborator

I'm following the "Hands-on: Interpretation of Search GUI" step, which instructs to set: "Compress results into a single zip file": Yes:

Screenshot 2020-10-15 at 19 14 51

However, when I run the tool with this parameter, there is only one output produced that is a zipped dataset:

Screenshot 2020-10-15 at 19 19 10

And I can't select any individual reports for the next two "Select" steps. When I check what parameters were used when I ran the workflow, I see that the parameter is set to: "Compress results into a single zip file": No:

Screenshot 2020-10-15 at 19 14 45

Also, in the workflow only 4 reports are selected to be generated instead of all reports (as shown in the tutorial).

Please update this step in the tutorial to be sure that usable datasets are produced. I suspect you can either set "Compress results into a single zip file" and "Also export reports out of the zip" parameters both to Yes or set both to No to make sure the individual reports are generated in the history.

> ### {% icon hands_on %} Hands-on: Search sequence databases
> 1. {% tool [Search GUI](toolshed.g2.bx.psu.edu/repos/galaxyp/peptideshaker/search_gui/3.3.10.1) %} with the following parameters:
> - {% icon param-file %} *"Protein Database"*: `ProteinDB_cRAP.fasta`
> - {% icon param-file %} *"Input Peak Lists (mgf)"*: `output` (output of **msconvert** {% icon tool %})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> - {% icon param-file %} *"Input Peak Lists (mgf)"*: `output` (output of **msconvert** {% icon tool %})
> - {% icon param-collection %} *"Input Peak Lists (mgf)"*: `output` (output of **msconvert** {% icon tool %})

@subinamehta
Copy link
Contributor Author

subinamehta commented Oct 15, 2020 via email

@malloryfreeberg
Copy link
Collaborator

malloryfreeberg commented Oct 15, 2020

I dont think that should be right..the input is mzml..if that is then it is a problem

Weird. This is what I see when I look at my history from running the workflow (which was successful):

Screenshot 2020-10-15 at 20 23 38

@subinamehta
Copy link
Contributor Author

I dont think that should be right..the input is mzml..if that is then it is a problem

Weird. This is what I see when I look at my history from running the workflow (which was successful):

Screenshot 2020-10-15 at 20 23 38

Yeah..it ran but FlashLFQ might have given empty output...
I made changes to the workflow..It was a WIP when the tutorial was created..so I think I didnt realize that there was an error in the replace expression..Thankyou for catching this.

@malloryfreeberg
Copy link
Collaborator

Yeah..it ran but FlashLFQ might have given empty output...
I made changes to the workflow..It was a WIP when the tutorial was created..so I think I didnt realize that there was an error in the replace expression..Thankyou for catching this.

Thanks for the explanation. I'll re-run the updated workflow and continue working through the tutorial step-by-step as well.

@malloryfreeberg
Copy link
Collaborator

Hi @subinamehta

The tutorial is great! 🎉 🎉 🎉 It's clear a lot of work went into creating it, so kudos to you and all the other contributors for a job well done.

The last thing to look at is the newest version of the workflow. After running it, a few of the datasets are empty: items 27, 30, and 34 in this history.

Just want to check whether this was expected, or if the workflow needs adjusted. I think this is the last change before merging!

@subinamehta
Copy link
Contributor Author

subinamehta commented Oct 15, 2020 via email

Copy link
Collaborator

@malloryfreeberg malloryfreeberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Great job @subinamehta ! 🎉

Happy for you to merge now, @shiltemann 👍

@shiltemann shiltemann merged commit 31f4a26 into galaxyproject:master Oct 16, 2020
@shiltemann
Copy link
Member

awesome, thanks @subinamehta and team! And thanks @malloryfreeberg for the great review! 🎉

@subinamehta
Copy link
Contributor Author

subinamehta commented Oct 16, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants