Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce auto generated screenshots in rule-based uploader #2270

Closed
wants to merge 3 commits into from

Conversation

OlegZharkov
Copy link
Contributor

Replace screenshots by images produced by selenium in https://github.com/galaxyproject/ci-testing
The corresponding selenium tests are marked in galaxyproject/galaxy#11171 and galaxyproject/galaxy#10911

Please deploy locally and assure that all screenshots are correct.

@OlegZharkov OlegZharkov requested review from a team as code owners January 19, 2021 13:36
@hexylena
Copy link
Member

Hey @OlegZharkov super exciting! Would you mind reverting your changes to the Gemfile and Gemfile.lock please

@OlegZharkov
Copy link
Contributor Author

Hey @OlegZharkov super exciting! Would you mind reverting your changes to the Gemfile and Gemfile.lock please

I actually did, it's a Github Bug. I did force push my changes, here's new diff

However it's not updating this PR. Do I really have to create a new PR?

@hexylena
Copy link
Member

Looks like a caching issue and the cache has already expired, the diff looked incorrect the first time I opened it, and correct just now.

@hexylena
Copy link
Member

But you've already opened a new one so we can move discussion there.

@OlegZharkov
Copy link
Contributor Author

OlegZharkov commented Jan 19, 2021

Looks like a caching issue and the cache has already expired, the diff looked incorrect the first time I opened it, and correct just now.

definitely not a browser cache. I tried to open in incognito, didn't help.
I wanted to close-reopen this PR and it didn't allow me to re-open because it was forced-pushed... so yeah, I kinda had to open the new one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants