New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce auto generated screenshots in rule-based uploader #2271
Conversation
6afc060
to
22338e9
Compare
topics/galaxy-interface/tutorials/upload-rules-advanced/tutorial.md
Outdated
Show resolved
Hide resolved
awesome!! |
Checked again, it seems the new images have propagated. many have the upload tooltip shown even when the button is inactive. E.g. here: And here: Sorry to be so picky about the images @OlegZharkov , just don't want to run the risk of confusing users into clicking the upload button too soon. |
I see, I thought it's the desired behavior. That was one of the images where the tooltip just start appearing, but didn't fully appear yet. I added the wait statement specifically for that tooltip to appear. |
Oh! Sorry for the confusion. It was only for the one screenshot directly
before where the user should be submitting the job. Here it's activated
even when they're actively editing other components.
What would be most helpful from our side? Should I go screenshot by
screenshot and list any changes or so?
Oleg Zharkov <notifications@github.com> schrieb am Di., 23. Feb. 2021,
12:29:
… many have the upload tooltip shown even when the button is inactive
I see, I thought it's the desired behavior. That was one of the images
where the tooltip just start appearing, but didn't fully appear yet. I
added the wait statement specifically for that tooltip to appear.
Ok then, thanks for reporting, I will look into it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2271 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADP7O5SXHOBHLZ3DM3HRJTTAOGMVANCNFSM4WIZWMUQ>
.
|
No worries. I will try to somehow hide it first. |
bbb7022
to
054417b
Compare
054417b
to
1cbeaea
Compare
@hexylena can you take a look, please? After galaxyproject/galaxy#11541 was merged, I made a new set of screenshots. They all seem to look fine to me and I hope the problems are gone.Thanks a lot for working on this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉🎉 You've done it @OlegZharkov!!!!! This is 💯 perfect, they match near perfectly, this is it!
thanks a lot @hexylena!! |
Wow, this is super cool @OlegZharkov ! I would love to do this for all the snippets too, so that they stay up to date more easiley, very nice work! 🎉 |
Replace screenshots by images produced by selenium in https://github.com/galaxyproject/ci-testing
The corresponding selenium tests are marked in galaxyproject/galaxy#11171 and galaxyproject/galaxy#10911
Please deploy locally and assure that all screenshots are correct.