Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce auto generated screenshots in rule-based uploader #2271

Merged
merged 6 commits into from Mar 16, 2021

Conversation

OlegZharkov
Copy link
Contributor

Replace screenshots by images produced by selenium in https://github.com/galaxyproject/ci-testing
The corresponding selenium tests are marked in galaxyproject/galaxy#11171 and galaxyproject/galaxy#10911

Please deploy locally and assure that all screenshots are correct.

@shiltemann
Copy link
Member

awesome!!

@hexylena
Copy link
Member

hexylena commented Feb 10, 2021

More major:

This one is empty, previously it was not. It occurs twice.

old new

Very minor, here the popup is faded out.

https://camo.githubusercontent.com/c5451dad57f2ca29c77ef0869bde9ca5f70b7db252eb06e8886ccb417300cadf/68747470733a2f2f67616c6178792d74657374732e73332e616d617a6f6e6177732e636f6d2f67616c6178792d67746e2d73637265656e73686f74732f6c6f63616c2f72756c65735f6578616d706c655f365f375f6e616d65642e706e67

Everything else is absolutely perfect and I'm SO excited to see this :)

@hexylena
Copy link
Member

Checked again, it seems the new images have propagated.
The issue described above was fixed, awesome. But I'm seeing something new that's odd:

many have the upload tooltip shown even when the button is inactive. E.g. here:

And here:

image

Sorry to be so picky about the images @OlegZharkov , just don't want to run the risk of confusing users into clicking the upload button too soon.

@OlegZharkov
Copy link
Contributor Author

many have the upload tooltip shown even when the button is inactive

I see, I thought it's the desired behavior. That was one of the images where the tooltip just start appearing, but didn't fully appear yet. I added the wait statement specifically for that tooltip to appear.
Ok then, thanks for reporting, I will look into it.

@hexylena
Copy link
Member

hexylena commented Feb 23, 2021 via email

@OlegZharkov
Copy link
Contributor Author

Oh! Sorry for the confusion. It was only for the one screenshot directly before where the user should be submitting the job. Here it's activated even when they're actively editing other components. What would be most helpful from our side? Should I go screenshot by screenshot and list any changes or so?

No worries. I will try to somehow hide it first.

@OlegZharkov OlegZharkov force-pushed the s3_automation branch 2 times, most recently from bbb7022 to 054417b Compare March 10, 2021 18:05
@OlegZharkov
Copy link
Contributor Author

@hexylena can you take a look, please? After galaxyproject/galaxy#11541 was merged, I made a new set of screenshots. They all seem to look fine to me and I hope the problems are gone.Thanks a lot for working on this!

Copy link
Member

@hexylena hexylena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉 You've done it @OlegZharkov!!!!! This is 💯 perfect, they match near perfectly, this is it!

@hexylena hexylena merged commit af8f5f1 into galaxyproject:master Mar 16, 2021
@OlegZharkov
Copy link
Contributor Author

You've done it @OlegZharkov!!!!! This is perfect, they match near perfectly, this is it!

thanks a lot @hexylena!!

@shiltemann
Copy link
Member

Wow, this is super cool @OlegZharkov ! I would love to do this for all the snippets too, so that they stay up to date more easiley, very nice work! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants