Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a list of abbreviations with meanings to the High Throughput Molecular Dynamics and Analysis Tutorials (Computational Chemistry) in response to feedbacks #2979

Merged
merged 7 commits into from
Nov 3, 2021

Conversation

Ezichi-Fav
Copy link
Contributor

I updated the contributors.yaml file and Added a list of abbreviations with meanings to the High Throughput Molecular Dynamics and Analysis Tutorials (Computational Chemistry) in response to feedbacks.

Ezichi-Fav and others added 5 commits October 31, 2021 06:52
…hput Molecular Dynamics and Analyses" (Computational Chemistry). issue galaxyproject#2978
Patch 1- Added  abbreviations to the High Throughput Molecular Dynamics and Analysis Tutorials (Computational Chemistry) in response to feedbacks
@Ezichi-Fav Ezichi-Fav requested a review from a team as a code owner November 3, 2021 06:24
@bebatut
Copy link
Member

bebatut commented Nov 3, 2021

Thanks @Ezichi-Fav.
@simonbray could you have a look at this PR? Thanks a lot

Copy link
Member

@simonbray simonbray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Ezichi-Fav, thanks a lot for the contribution! I wrote a few comments.

In general, I think it's important that the users understand what the abbreviations mean, not only what they stand for, so I suggested a few places where some more detail could be added. For example, to know what CHARMM stands for is not as important as to know what it actually is (a force field). :)

@@ -41,6 +41,36 @@ This tutorial provides an introduction to using high-throughput molecular dynami
>
{: .agenda}


# Abbreviations
* **Hsp90** –Heat Shock Protein 90 <br>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* **Hsp90** Heat Shock Protein 90 <br>
* **Hsp90** - Heat Shock Protein 90

Can you make sure you format the same on each line? With 1 space before and after the dash.

Also, the <br> tag should not be needed.

* **MD**- Molecular Dynamics Simulation<br>
* **PDB**- Protein Data Bank<br>
* **GROMACS**- Groningen Machine for Chemical Simulation. It is a molecular dynamics package mainly designed for simulations of proteins, lipids and nucleic acids. <br>
* **GRO files**- GROMAC Format<br>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* **GRO files**- GROMAC Format<br>
* **GRO files**- structure file in GROMACS format

* **PDB**- Protein Data Bank<br>
* **GROMACS**- Groningen Machine for Chemical Simulation. It is a molecular dynamics package mainly designed for simulations of proteins, lipids and nucleic acids. <br>
* **GRO files**- GROMAC Format<br>
* **DCD** - Dynamics CoorDinate files<br>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* **DCD** - Dynamics CoorDinate files<br>
* **DCD** - trajectory format supported by CHARMM and NAMD (Dynamics CoorDinate)

Comment on lines 52 to 54
* **RSMD**-Root Mean Square Deviation<br>
* **RSMF**- Root Mean Square Fluctuation<br>
* **PCS**- Principal Components analysis<br>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you check spelling of these 3 abbreviations here?

Comment on lines 57 to 58
* **TRR**- trajectory file (coordinates and velocity) <br>
* **XTC**- trajectory file (coordinates only) <br>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mention here TRR and XTC are supported by GROMACS

* **TRR**- trajectory file (coordinates and velocity) <br>
* **XTC**- trajectory file (coordinates only) <br>
* **ACPYPE tool**- AnteChamber Python Parser interface<br>
* **GROMOS**- GROningen Molecular Simulation<br>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* **GROMOS**- GROningen Molecular Simulation<br>
* **GROMOS**- force field (GROningen Molecular Simulation)

can you make the same change for the next three force fields as well?

* **AMBER**- Assisted Model building with Energy Refinement<br>
* **OpenFF**-Open Force Field<br>
* **TIP3P**- A water model that specifies rigid water molecules with charges and Lennard-Jones Paramenters assigned to each of the 3 atoms<br>
* **ITP files**- Atom Topologies (charges, mass, radii etc) <br>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mention it is a GROMACS file format

* **NVT**- constant number (N), Volume (V) Temperature (T) <br>
* **NPT**- constant number (N) , Pressure (P), Temperature (T) <br>
* **NMR**- Nuclear Magnetic Resonance<br>
* **VMD**- Visual Molecular Dynamics <br>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* **VMD**- Visual Molecular Dynamics <br>
* **VMD**- Visual Molecular Dynamics, a visualization software

@simonbray simonbray merged commit 521a8d4 into galaxyproject:main Nov 3, 2021
@simonbray
Copy link
Member

thanks @Ezichi-Fav!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants