Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRISPR finalise #3219

Merged
merged 15 commits into from
Mar 7, 2022
Merged

CRISPR finalise #3219

merged 15 commits into from
Mar 7, 2022

Conversation

mblue9
Copy link
Contributor

@mblue9 mblue9 commented Mar 4, 2022

Few things to fix in slides

@mblue9 mblue9 changed the title [WIP]CRISPR finalise CRISPR finalise Mar 4, 2022
@mblue9
Copy link
Contributor Author

mblue9 commented Mar 4, 2022

Ready for review for Tapas if anyone can do it

@hexylena
Copy link
Member

hexylena commented Mar 7, 2022

@mblue9 I'm looking at this and #3220 and wondering if there's not some organisation that might make more sense, than having both in their own section.

What would you think about renaming genome annotation to genomics? Would this fit appropriately under genomics, if we made a subtopic for genome editing?

@hexylena
Copy link
Member

hexylena commented Mar 7, 2022

@mblue9 I'm working on this now! I'm made one small change, I'm replacing your **C**lustered **R**egularly... with {CRISPR}, and using the built in abbreviation plugin. This should be more friendly for screen-readers, as some will read emphasized letters separately from the rest of the word.

It looks like you're missing some alt-text for a few of the images. This was not caught in the initial round of linting due to an issue in the plugin which I've now fixed. Could you please provide alt text there?

@mblue9
Copy link
Contributor Author

mblue9 commented Mar 7, 2022

Thanks for working on this @hexylena !

@mblue9 I'm looking at this and #3220 and wondering if there's not some organisation that might make more sense, than having both in their own section.

What would you think about renaming genome annotation to genomics? Would this fit appropriately under genomics, if we made a subtopic for genome editing?

Yes that makes sense to me, should I go ahead and create a topic for genomics with subtopic genome-editing?

@mblue9 I'm working on this now! I'm made one small change, I'm replacing your Clustered Regularly... with {CRISPR}, and using the built in abbreviation plugin. This should be more friendly for screen-readers, as some will read emphasized letters separately from the rest of the word.

Great thanks!

It looks like you're missing some alt-text for a few of the images. This was not caught in the initial round of linting due to an issue in the plugin which I've now fixed. Could you please provide alt text there?

Will do

@hexylena
Copy link
Member

hexylena commented Mar 7, 2022

I can handle the reorganisation, no dramas. It's pretty involved since we'll need to redirect all of the genome-annotation tutorials.

@hexylena
Copy link
Member

hexylena commented Mar 7, 2022

Question: are you planning more CRISPR tutorials? (We've had some internal discussion about the rearranging and struggling to find a good solution, I was too optimistic.)

@mblue9
Copy link
Contributor Author

mblue9 commented Mar 7, 2022

Question: are you planning more CRISPR tutorials? (We've had some internal discussion about the rearranging and struggling to find a good solution, I was too optimistic.)

I don't currently have plans for more. Was just looking at TN-seq tutorial and that's a similar concept (identifying essential genes) so maybe we put this under genome-annotation too as CRISPR can be used for identifying/annotating gene functions. This tutorial is not really about annotating genomes (it's determining action of a drug) but if it's better to put it there rather than in a topic on it's own we could do that?

@hexylena
Copy link
Member

hexylena commented Mar 7, 2022

Ok, that works for now then

@mblue9 mblue9 requested a review from a team as a code owner March 7, 2022 16:13
hexylena
hexylena previously approved these changes Mar 7, 2022
@hexylena hexylena merged commit 5ec7936 into galaxyproject:main Mar 7, 2022
@mblue9
Copy link
Contributor Author

mblue9 commented Mar 7, 2022

Thanks a lot @hexylena !

@hexylena
Copy link
Member

hexylena commented Mar 7, 2022

Sure thing @mblue9 !! Great to see more tutorials :)

And one more thing: I'm sorry I missed this @mblue9, it looks like one slide is missing speaker notes:

image

unfortunately that will break the autogenerated video. Would you mind adding notes for that?

@mblue9
Copy link
Contributor Author

mblue9 commented Mar 7, 2022

Fixed here @hexylena

@mblue9
Copy link
Contributor Author

mblue9 commented Mar 8, 2022

Hi @hexylena just wondering if I need to do anything to get the autogenerated video to show up here?
https://training.galaxyproject.org/training-material/videos/watch.html?v=/genome-annotation/tutorials/crispr-screen/slides

@hexylena
Copy link
Member

hexylena commented Mar 8, 2022

No, nothing you need to do. Look like something's gone wrong with the video generation.
I'll look into it. https://github.com/galaxyproject/training-material/actions/workflows/video.yml

@mblue9
Copy link
Contributor Author

mblue9 commented Mar 8, 2022

Ok great thanks!

@hexylena
Copy link
Member

hexylena commented Mar 9, 2022

I'm struggling to get the video building working again, something is wrong with the dependencies and I don't know what, I can't reproduce it locally. I'll build the video manually, locally. and upload it.

@mblue9
Copy link
Contributor Author

mblue9 commented Mar 9, 2022

Ok thanks @hexylena !
I just realised I should probably add some pronounciations into https://github.com/galaxyproject/training-material/blob/main/bin/ari-map.yml
e.g CRISPR = crisper
have you already made the video or will I do that first?

@hexylena
Copy link
Member

hexylena commented Mar 9, 2022

I've made it, https://training.galaxyproject.org/training-material/videos/watch.html?v=/genome-annotation/tutorials/crispr-screen/slides you can use it to check pronunciation and I'll re-make it whenever you're done :)

@mblue9
Copy link
Contributor Author

mblue9 commented Mar 9, 2022

I've made it, https://training.galaxyproject.org/training-material/videos/watch.html?v=/genome-annotation/tutorials/crispr-screen/slides you can use it to check pronunciation and I'll re-make it whenever you're done :)

Great, done here #3236

@mblue9
Copy link
Contributor Author

mblue9 commented Mar 9, 2022

Forgot to say I got asked if the slides robot voice could have an Oz accent but I assume that's not possible 😆

@hexylena
Copy link
Member

hexylena commented Mar 10, 2022 via email

@mblue9
Copy link
Contributor Author

mblue9 commented Mar 10, 2022

Oh defo possible! Only the woman's voice is good, the man's a bit synthetic
sounding. I'll get that swapped in for ya. We can have her goin on about
how grouse crispr is in no time 🤣

😃 Ohh brilliant!! 🙌 🎉

@shiltemann
Copy link
Member

This is so cool! Thanks @mblue9! I think I am going to do this tutorial myself during Smorg next week, this looks very intersting :)

@mblue9
Copy link
Contributor Author

mblue9 commented Mar 10, 2022

Aw thanks @shiltemann 🥰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants