Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated ga file for imaging tutorial: Introduction to image analysis using Galaxy #4492

Merged
merged 7 commits into from
Dec 5, 2023

Conversation

thawn
Copy link
Contributor

@thawn thawn commented Nov 7, 2023

updated ga file for imaging tutorial:
Introduction to image analysis using Galaxy

closes Imaging introduction (workflow) uses non-existent tool
fixes #4469

updated ga file for imaging tutorial:
Introduction to image analysis using Galaxy

closes Imaging introduction (workflow) uses non-existent tool galaxyproject#4469
hexylena
hexylena previously approved these changes Nov 8, 2023
Copy link
Member

@hexylena hexylena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic, thanks so much @thawn !

"output_name": "output"
"a_galaxy_workflow": "true",
"annotation": "",
"format-version": "0.1",
Copy link
Contributor

@kostrykin kostrykin Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the complaints from the linter:

  1. Add a line with "license": "MIT" or some other OSI license here?

  2. Add the a Creaetor block, like this or something similar?

"creator":[
      {
         "class":"Person",
         "identifier":"https://orcid.org/xxxx-xxxx-xxxx-xxxx",
         "name":"xxx xxx",
         "url":"xxx"
      }
   ],

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kostrykin, these can most easily be filled in Galaxy itself, using the "Best Practices" tab which will give you a nice form for entering them correctly.

Here's where you find the best practices:
image

Following through with the suggestions will let you fix all best-practice issues:
image

Or if you just want to fix the linting complaints and nothing else, this can be done from the edit tab:
image

"url":"https://github.com/thawn/"
}
],
"license": "MIT"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a , missing at the end of the line

@thawn
Copy link
Contributor Author

thawn commented Nov 9, 2023

@hexylena I managed to create the workflow tests with planemo following the tutorial. However, I was not able to run the tests myself: planemo test returned No tests were executed - see Galaxy output for details.

@thawn
Copy link
Contributor Author

thawn commented Nov 9, 2023

It seems that the tests succeeded in the CI, but it would be great if I could also run the test locally to be sure before committing the changes

@hexylena hexylena merged commit 76780fe into galaxyproject:main Dec 5, 2023
2 checks passed
@hexylena
Copy link
Member

hexylena commented Dec 5, 2023

Thanks for your patience and hard work @thawn !

@thawn
Copy link
Contributor Author

thawn commented Dec 6, 2023

you are very welcome 😄

@thawn
Copy link
Contributor Author

thawn commented Dec 6, 2023

and thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imaging introduction (workflow) uses non-existent tool
3 participants