Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTN Header - Adding a Answer Key Histories drop-down menu #4881

Merged
merged 10 commits into from
May 13, 2024

Conversation

nomadscientist
Copy link
Collaborator

@nomadscientist nomadscientist commented Apr 4, 2024

This is the first attempt to get the conversation started

I'm wondering if it would be ideal to have a landing page, like with the workflows, where we stipulate how to import a history, compare, and drag datasets between histories so they can help themselves if they get stuck.

Fixes #4594

@nomadscientist nomadscientist requested a review from a team as a code owner April 4, 2024 11:18
Realised I also need to follow up on another PR to add that troubleshooting snippet here!
Copy link
Member

@hexylena hexylena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting the conversation started!

I've proposed a more structured data format, and it's an interesting idea about the histories index. I'm not sure how best to handle that.

You would envision people going to this separate page to see the available histories?

And I guess I wonder what we want to do in the future, with the workflow testing framework, if we should plan to attach these to specific workflows (somehow).

@nomadscientist
Copy link
Collaborator Author

I think the answer key history list should be a drop-down menu, and then the final option (or first option, depending) should ALWAYS be the history_index.md that I started, labelled "Using history answer keys" as the button. So if they understand, they can just click the history and it imports it, or if they don't, they can select 'using history answer keys' to learn

@nomadscientist
Copy link
Collaborator Author

I put an 'input histories' there, but actually, that's probably not necessary (although I could absolutely see a future wherein the 'Get data' sections automatically pull from the input histories just like they pull from Zenodo, but it's not strictly needed atm).

I think mentally I was thinking it would be valuable to quickly see which tutorials have input histories and which don't, so that we could make the input histories and keep everything up to date, but that probably goes with the whole workflow / history / automation plan and isn't necessary NOW, so happy for it to be binned.

@hexylena
Copy link
Member

hexylena commented Apr 4, 2024

I think this is a good interim plan. We can make something like this work

@nomadscientist
Copy link
Collaborator Author

Ahk, bad me, I've put this in two places
#4594
Well when we make this work then we can resolve that issue!

@hexylena
Copy link
Member

Ahk, bad me, I've put this in two places
#4594

no this is fine, perfect even. you filed an issue to see if the implementation was reasonable/desired, we agreed, and now you've opened a PR to implement this (which we will get around to eventually i promise). I've tagged this PR as "Fixes #4594" which will ensure that when this is merged the associated issue is auto-closed.

that's a great workflow! Especially for feature requests where you want feedback on if it's possible or so.

@hexylena
Copy link
Member

Looks good I think, added an optional 'date' field that can be used (or not, or automatically extracted from the history/etc).

Screenshot 2024-05-13 at 15-59-55 Single Cell _ Hands-on Generating a single cell matrix using Alevin

hexylena
hexylena previously approved these changes May 13, 2024
hexylena
hexylena previously approved these changes May 13, 2024
@hexylena hexylena merged commit 48d0f4f into galaxyproject:main May 13, 2024
2 of 3 checks passed
@nomadscientist
Copy link
Collaborator Author

Woooo!

@hexylena hexylena added the todo-news TODO: write this up into news / other documentstion label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributing faqs single-cell template-and-tools todo-news TODO: write this up into news / other documentstion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Example history in header
2 participants