Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme fix and allow tinymce theme choice from javascript helper #4

Merged
merged 10 commits into from Jan 2, 2012

Conversation

matenia
Copy link
Contributor

@matenia matenia commented Jan 2, 2012

  • reformatted README
  • added second param option to tinymce_managed_javascript_tag to allow using the simple theme
  • fixed locales file

If this request is ok, I have also modified it for the rails3 branch

mlitwiniuk added a commit that referenced this pull request Jan 2, 2012
Readme fix and allow tinymce theme choice from javascript helper
@mlitwiniuk mlitwiniuk merged commit f87d466 into galdomedia:master Jan 2, 2012
@mlitwiniuk
Copy link
Member

Great job, thanks! Soon I'll be converting this plugin into gem, but it will be probably Rails >3.1 only.

@matenia
Copy link
Contributor Author

matenia commented Jan 2, 2012

even better :D . I have been using this as a plugin in some rails 3.1 projects only just started so not aware of any bugs as yet regarding the image management. I'll send through the rails3 branch update now too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants