Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shortcut spec LEFT and RIGHT #84

Closed
claytonneal opened this issue Aug 3, 2014 · 5 comments
Closed

Add shortcut spec LEFT and RIGHT #84

claytonneal opened this issue Aug 3, 2014 · 5 comments

Comments

@claytonneal
Copy link

For above/below there is shortcut specs
However for LEFT and RIGHT the only spec is NEAR - which a Range is mandatory
It would be great just to be able to specif LEFT and RIGHT with no range..

@ishubin ishubin added c3 labels Aug 3, 2014
@ishubin
Copy link
Member

ishubin commented Aug 3, 2014

Thanks, for the idea! I have been thinking about this but didn't know which words to choose as a shortcut. The thing is Galen Spec Language was designed to be human readable and I would like not to break this readability. In this case the specs "above" and "below" match perfectly because you can read the spec like this: "object-a is above object-b". But if we take the keywords "left" and "right" it would be read like: "object-a is left object-b" which doesn't really make sense. Perhaps the combination "from left" and "from right" would work but it is also debatable.

@claytonneal
Copy link
Author

how about "LEFT OF" and "RIGHT OF" ?

@ishubin ishubin added p3 and removed p4 labels Mar 9, 2015
@ishubin
Copy link
Member

ishubin commented Mar 9, 2015

Sorry for late response. I think "left of" and "right of" makes sense, thanks for suggestions. Will build it for release-1.6 or next one

@ghost
Copy link

ghost commented Mar 16, 2015

You haven't added those two functions in galen-pagedump.js

@ishubin
Copy link
Member

ishubin commented Mar 16, 2015

@phystem oops :) thanks for reminding that one. will fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants