Init golang module

[ninedraft]

Init golang modules to pin dependencies

[coveralls]

Coverage remained the same at 95.298% when pulling 1eff170 on ninedraft:init-go-module into 4c378b9 on galeone:master.

[galeone]

I'm not completely familiar with go.mod, can you explain to me exactly what every line of the file does?

require github.com/tensorflow/tensorflow v2.1.0+incompatible

I mean, it looks that explicit the dependencies, however, as I wrote in the readme, we should depend on the fork I created, otherwise we have a problem with the compiled protocol buffers that are not available in the tensorflow official repo.

Moreover, I see the go version: 1.15. That's not enough for TensorFlow (and thus, tfgo), it's too general. We need to depend on a specific minor version, or better, we have to exclude a specific minor version.

The TensorFlow Go bindings use a lot of opaque struct pointers, that in version 1.15.3 are broken ( golang/go#42032 ), thus we should be able to explicit: every go version != 1.15.3. Something like go >= 1.15, !=1.15.3 is it possible?

[galeone]

I see the new commit with the latest change, is this line correct?

replace github.com/tensorflow/tensorflow => github.com/galeone/tensorflow v1.12.2-0.20201110143501-1b6f13331f4d

I understand that this is used to replace with galeone/tensorflow, but is this pointing to the correct branch? The correct branch is r2.3-go

[ninedraft]

I mean, it looks that explicit the dependencies, however, as I wrote in the readme, we should depend on the fork I created, otherwise we have a problem with the compiled protocol buffers that are not available in the tensorflow official repo.

You are right, I fixed go.mod to use your fork

[ninedraft]

Go mod reference can be found here: https://golang.org/ref/mod

[galeone]

👍 but is it pointing to branch r.2.3-go of my fork?

It looks like is pointing to another branch

[ninedraft]

The TensorFlow Go bindings use a lot of opaque struct pointers, that in version 1.15.3 are broken ( golang/go#42032 ), thus we should be able to explicit: every go version != 1.15.3. Something like go >= 1.15, !=1.15.3 is it possible?

I think not, I think it can be achieved by using build tag https://golang.org/cmd/go/#hdr-Build_constraints

[ninedraft]

👍 but is it pointing to branch r.2.3-go of my fork?
It looks like is pointing to another branch

You're right, my fault!

I'll fix it as soon I'l get to my laptop

[ninedraft]

done

[galeone]

Thank you @ninedraft 👍

Merging it right now.

About the build tags it looks like there isn't the support to specify the Go compiler, looking at the doc you linked. I'll give another look in the future (as soon as I have time) - but in the meantime, thank you for letting me know about this feature!