Assets pipeline in ckfinder. Fix for rails 4 #276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
1 similar comment
|
👍 |
|
👍 |
1 similar comment
|
👍 |
|
Any idea if this will be merged soon? |
|
Yes, that would be great, because else we cannot use the gem anymore... |
|
@botularius you could by specifing vlademir-e's commit directly in your Gemfile, altough I wouldn't recommend it. |
|
👍 |
|
shouldn't this be within view_helper instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config.assets.enabledwas removed from Rails sinceRails 4and this option returns nil now.I added another condition to make ckfinder's assets load properly in
Rails 4.