Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dynamic file fields work on contributions and transactions #304

Merged
merged 1 commit into from Sep 25, 2023

Conversation

trasher
Copy link
Member

@trasher trasher commented Sep 25, 2023

closes #1697

@codecov-commenter
Copy link

Codecov Report

Merging #304 (0f1bac8) into develop (33d7217) will decrease coverage by 0.03%.
The diff coverage is 9.89%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@              Coverage Diff              @@
##             develop     #304      +/-   ##
=============================================
- Coverage      43.69%   43.66%   -0.03%     
- Complexity      5852     5854       +2     
=============================================
  Files            142      142              
  Lines          23757    23770      +13     
=============================================
- Hits           10381    10380       -1     
- Misses         13376    13390      +14     
Files Changed Coverage Δ
...lette/Controllers/Crud/DynamicFieldsController.php 0.00% <0.00%> (ø)
...lib/Galette/Controllers/Crud/MembersController.php 0.00% <ø> (ø)
galette/lib/Galette/Features/Replacements.php 86.47% <0.00%> (-0.16%) ⬇️
galette/lib/Galette/Features/Dynamics.php 50.85% <28.57%> (-0.63%) ⬇️
galette/lib/Galette/Entity/DynamicFieldsHandle.php 52.91% <100.00%> (-1.49%) ⬇️
...alette/lib/Galette/Repository/DynamicFieldsSet.php 93.75% <100.00%> (+1.44%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@trasher trasher merged commit 0f1bac8 into develop Sep 25, 2023
13 of 14 checks passed
@trasher trasher deleted the feature/fix/1697 branch September 28, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants