-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix batch actions JS for group managers; fixes #1702 #306
Fix batch actions JS for group managers; fixes #1702 #306
Conversation
3457dd1
to
08b0fe7
Compare
@@ -134,7 +134,7 @@ | |||
$(function(){ | |||
{% if batch is defined and batch_actions is defined and batch_actions|length > 0 %} | |||
var _init_page = function(res){ | |||
{% if login.isAdmin() or login.isStaff() %} | |||
{% if login.isAdmin() or login.isStaff() or login.isGroupManager() %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, this seems to be enough to fix batch actions for group managers in core and existing plugins (galette/plugin-events#30 is required for plugin-events).
Please, have a deeper look to check the possible deleted parts of code you were talking about previously, and change the draft status of this PR at your will.
I checked as admin, staff, group manager and member, and ACLs and rights settings appear to be respected in each case everywhere batch actions are available (members, contributions, transactions, cars models, cars, bookings).
Let me know if I missed anything 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think e028062 is enough; if you're OK with that, we can merge this one :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with that 👍 🚀
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## develop #306 +/- ##
=============================================
- Coverage 44.36% 43.65% -0.71%
+ Complexity 5864 5858 -6
=============================================
Files 142 142
Lines 23797 23776 -21
=============================================
- Hits 10557 10380 -177
- Misses 13240 13396 +156 see 28 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
08b0fe7
to
e028062
Compare
e028062
to
9737e2b
Compare
No description provided.