Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix batch actions JS for group managers; fixes #1702 #306

Merged

Conversation

gagnieray
Copy link
Collaborator

No description provided.

@trasher trasher marked this pull request as draft September 26, 2023 14:10
@gagnieray gagnieray force-pushed the feature/batch-actions-rectrictions branch from 3457dd1 to 08b0fe7 Compare September 26, 2023 21:35
@@ -134,7 +134,7 @@
$(function(){
{% if batch is defined and batch_actions is defined and batch_actions|length > 0 %}
var _init_page = function(res){
{% if login.isAdmin() or login.isStaff() %}
{% if login.isAdmin() or login.isStaff() or login.isGroupManager() %}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this seems to be enough to fix batch actions for group managers in core and existing plugins (galette/plugin-events#30 is required for plugin-events).

Please, have a deeper look to check the possible deleted parts of code you were talking about previously, and change the draft status of this PR at your will.

I checked as admin, staff, group manager and member, and ACLs and rights settings appear to be respected in each case everywhere batch actions are available (members, contributions, transactions, cars models, cars, bookings).

Let me know if I missed anything 😊

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think e028062 is enough; if you're OK with that, we can merge this one :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with that 👍 🚀

@gagnieray gagnieray changed the title Fix batch actions for group managers; fix #1702 Fix batch actions JS for group managers; fixes #1702 Sep 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023

Codecov Report

Merging #306 (08b0fe7) into develop (9b92373) will decrease coverage by 0.71%.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

❗ Current head 08b0fe7 differs from pull request most recent head 9737e2b. Consider uploading reports for the commit 9737e2b to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@              Coverage Diff              @@
##             develop     #306      +/-   ##
=============================================
- Coverage      44.36%   43.65%   -0.71%     
+ Complexity      5864     5858       -6     
=============================================
  Files            142      142              
  Lines          23797    23776      -21     
=============================================
- Hits           10557    10380     -177     
- Misses         13240    13396     +156     

see 28 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@trasher trasher force-pushed the feature/batch-actions-rectrictions branch from 08b0fe7 to e028062 Compare October 5, 2023 12:30
@trasher trasher marked this pull request as ready for review October 5, 2023 12:32
@trasher trasher force-pushed the feature/batch-actions-rectrictions branch from e028062 to 9737e2b Compare October 5, 2023 12:36
@trasher trasher merged commit c51101f into galette:develop Oct 5, 2023
13 of 14 checks passed
@gagnieray gagnieray deleted the feature/batch-actions-rectrictions branch October 5, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants