Generate and store dark CSS file #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## develop #346 +/- ##
=============================================
- Coverage 44.18% 44.18% -0.01%
- Complexity 5902 5903 +1
=============================================
Files 142 142
Lines 23915 23917 +2
=============================================
Hits 10567 10567
- Misses 13348 13350 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This PR is far to be finished, but I already cause some issues:
|
|
Also, maybe using the extension for users who need it is also a good solution (and requires 0 changes Galette side). |
Add Dark Reader in js dependencies Generate and store dark CSS file Better name for included file Rely on browser configuration to switch theme Tested with: - firefox - chrome (using chrome://flags/#enable-force-dark)
trasher
force-pushed
the
feature/darkmode
branch
from
4c0bd72
to
ebb60f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.