Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version checking #427

Merged
merged 2 commits into from Feb 18, 2024
Merged

New version checking #427

merged 2 commits into from Feb 18, 2024

Conversation

trasher
Copy link
Member

@trasher trasher commented Feb 16, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2024

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (a1fae4a) 45.64% compared to head (5fd6591) 45.65%.

Files Patch % Lines
galette/lib/Galette/Features/Cacheable.php 38.77% 30 Missing ⚠️
galette/lib/Galette/Util/Release.php 82.45% 10 Missing ⚠️
galette/lib/Galette/IO/News.php 53.84% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #427   +/-   ##
==========================================
  Coverage      45.64%   45.65%           
- Complexity      5936     5965   +29     
==========================================
  Files            143      145    +2     
  Lines          24171    24241   +70     
==========================================
+ Hits           11034    11067   +33     
- Misses         13137    13174   +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trasher
Copy link
Member Author

trasher commented Feb 17, 2024

image

@trasher
Copy link
Member Author

trasher commented Feb 17, 2024

Since I rely on flash messages; message is only displayed on the second loaded page... But as it's permanent and diplsayed on all pages once logged; this is not really an issue I guess.

@trasher trasher force-pushed the feature/check-release branch 7 times, most recently from da5509b to 3d9dcd8 Compare February 18, 2024 07:17
@trasher trasher marked this pull request as ready for review February 18, 2024 07:17
@trasher trasher merged commit 5fd6591 into develop Feb 18, 2024
35 checks passed
@trasher trasher deleted the feature/check-release branch February 18, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants