Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve toasts messages display #435

Merged
merged 2 commits into from Feb 20, 2024

Conversation

gagnieray
Copy link
Collaborator

Use top attached position variation
Use close icon
Use Progress bar on messages with display time

Use top attached position variation
Use close icon
Use Progress bar on messages with display time
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (75e7d96) 45.64% compared to head (08f9bc1) 45.64%.

Files Patch % Lines
galette/lib/Galette/Controllers/AjaxController.php 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #435   +/-   ##
==========================================
  Coverage      45.64%   45.64%           
  Complexity      5965     5965           
==========================================
  Files            145      145           
  Lines          24245    24245           
==========================================
  Hits           11067    11067           
  Misses         13178    13178           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trasher trasher merged commit 08f9bc1 into galette:develop Feb 20, 2024
18 checks passed
@gagnieray gagnieray deleted the feature/toast-messages branch February 20, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants