Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ArcPathElement2d and ArcPathElement2dfx #38

Closed
sebpetit opened this issue May 17, 2016 · 3 comments
Closed

Create ArcPathElement2d and ArcPathElement2dfx #38

sebpetit opened this issue May 17, 2016 · 3 comments
Assignees
Milestone

Comments

@sebpetit
Copy link

sebpetit commented May 17, 2016

The constructors can be :
ArcPathElement2fp(double fromx, double fromy, double radiusx, double radiusy, double tox, double toy)
ArcPathElement2fx(DoubleProperty fromx, DoubleProperty fromy, DoubleProperty radiusx, DoubleProperty radiusy, DoubleProperty tox, DoubleProperty toy)

@gallandarakhneorg gallandarakhneorg changed the title Create ArcPathElement2fp, ArcPathElement2fx Create ArcPathElement2d and ArcPathElement2dfx May 17, 2016
@gallandarakhneorg
Copy link
Owner

gallandarakhneorg commented May 17, 2016

The creation of these path elements will be done through the following function on paths:

  • arcTo(double ctrlx, double ctrly, double radiusx, double radiusy, double tox, double toy)
  • arcTo(double radiusX, double radiusY, double ellipseRotation, boolean largeArc, boolean sweepArc, double tox, double toy)

No new path element type will be created since the arcTo functions are invoking the curveTo function.

@gallandarakhneorg gallandarakhneorg added this to the 13.0 milestone May 17, 2016
gallandarakhneorg added a commit that referenced this issue May 20, 2016
see #38

Signed-off-by: Stéphane Galland <galland@arakhne.org>
@sebpetit
Copy link
Author

sebpetit commented May 26, 2016

Is it possible to create an ArcPathElement2fx in PathElement2dxf to differentiate it from CurvePathElement2fx ?

In FXTL, in PathShape2D, we need to know when a PathElement2dfx has an ARC_TO type to create an ArcTo JavaFX object. We create a CubicCurveTo JavaFX object when a PathElement2dfx has a CURVE_TO type.

@gallandarakhneorg
Copy link
Owner

The JavaFX Path2D is creating a curve when its arcTo function is called. It means that a JavaFX Path2D never replies ArcTo path elements. Indeed, ArcTo path element exists in JavaFX, but is is created only by the PieChart region.

However, I may add this new type of path element, that will be at the end mapped to a curve.

@gallandarakhneorg gallandarakhneorg self-assigned this May 26, 2016
gallandarakhneorg added a commit that referenced this issue May 27, 2016
see #38

Signed-off-by: Stéphane Galland <galland@arakhne.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants