Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 20130709 2 #452

Merged
merged 4 commits into from
Jul 9, 2013
Merged

Fixes 20130709 2 #452

merged 4 commits into from
Jul 9, 2013

Conversation

shadlaws
Copy link
Member

@shadlaws shadlaws commented Jul 9, 2013

No description provided.

shadlaws and others added 4 commits July 9, 2013 11:19
Remove extension from cache busters of non-combined JS/CSS links (follows 2078)
--HG--
rename : modules/gallery/libraries/Gallery_View.php => modules/gallery/classes/Gallery/View.php
rename : modules/gallery/libraries/Gallery_View.php => modules/gallery/classes/Gallery/View/Gallery.php
shadlaws added a commit that referenced this pull request Jul 9, 2013
@shadlaws shadlaws merged commit 02c895f into gallery:kohana_3 Jul 9, 2013
@shadlaws shadlaws deleted the fixes_20130709_2 branch July 9, 2013 11:01
@@ -3,4 +3,4 @@
; process. You don't need to edit it. In fact..
;
; DO NOT EDIT THIS FILE BY HAND!
build_number=427
build_number=428
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, that's interesting. Normally I don't merge changes to .build_number between branches since each branch theoretically has its own build number. But that's generally for branches that are intended for some form of release and the kohana_3 branch isn't really headed that way.

I'm embarrassed to say that I have a client set up to do this, but I don't remember how I set it up. I think it has to do with putting:

[merge "merge-keep-ours"]
        name = Keep ours
        driver = git-merge-ours %O %A %B

in my .git/config - but that looks like it would keep the local copy in case of all conflicts. Come to think of it, that might actually work in the case where we're merging master down to a release branch since we typically don't do any real work in release branches.

Anyway - other funny thing is that if we merge this file down to kohana_3 we can relatively easily see when we have another merge to do...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants