Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added if (nh < 1) { var nh = 0; } #64

Merged
merged 1 commit into from
Dec 26, 2011
Merged

added if (nh < 1) { var nh = 0; } #64

merged 1 commit into from
Dec 26, 2011

Conversation

ophian
Copy link
Contributor

@ophian ophian commented Nov 5, 2011

to start album upper border not as nh = -n

to start album upper border not as nh = -n
@bharat
Copy link
Member

bharat commented Nov 24, 2011

I assume that this is fixing a visual bug, but I don't know how to reproduce it. Can you help me reproduce it so that I can better understand your fix? thanks!

@ophian
Copy link
Contributor Author

ophian commented Nov 25, 2011

Well, yes, ... (its not online, therefor I have to try and describe)
I converted an old gallery g2 to g3. There were some upright Albums thumbs with descriptions, which did not fit into the squared box. Because it was overflowing, the function rendered to minus ints and the thumb moved under the upper border, which did not look good at all. To - at least - have the upper border be the same in all album pics, I created this fix. It still has the issue with the bottom border, but this is less ugly....

bharat added a commit that referenced this pull request Dec 26, 2011
added 	  if (nh < 1) { var nh = 0; }

Fixes #1813
@bharat bharat merged commit 29d16f7 into gallery:master Dec 26, 2011
@bharat
Copy link
Member

bharat commented Dec 26, 2011

Thanks, ophian!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants