Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official release with ROP docs? #118

Closed
zachriggle opened this issue Sep 16, 2014 · 11 comments
Closed

Official release with ROP docs? #118

zachriggle opened this issue Sep 16, 2014 · 11 comments
Milestone

Comments

@zachriggle
Copy link
Member

The rop module is still lacking documentation on readthedocs. Any way we can cut a new release so the docs are up?

@TethysSvensson
Copy link
Contributor

Yes, with some luck, I will do a new release on Thursday. In the mean time, see http://pwntools.readthedocs.org/en/latest/

@zachriggle
Copy link
Member Author

A-ha! Thanks :)

@zachriggle
Copy link
Member Author

@TethysSvensson
Copy link
Contributor

I just saw that. No idea why, but looking into it.

@TethysSvensson
Copy link
Contributor

Ah. readthedocs cannot import ropgadget!

I will commit a fix soon.

@TethysSvensson
Copy link
Contributor

Done. Check the link now.

@zachriggle
Copy link
Member Author

Yey

@zachriggle
Copy link
Member Author

Hmm, I need to work on these a bit. There's a lot of black magic that's not documented so well.

@zachriggle
Copy link
Member Author

Would we be opposed to links in the docs to the pwntools-write-ups repo, or the examples directory? Some things are slightly more difficult do show useful examples for in a docstring.

Edit: I mean under a specific heading. For example, the pwnlib.tubes.ssh.ssh class has docs, but linking to a few examples would probably help. I just don't know if we want links in the docstring.

@TethysSvensson
Copy link
Contributor

You can link in a function docstring if you want, but as you say it is probably better to do it in either the module docstring or in the .rst file.

@TethysSvensson
Copy link
Contributor

Oh -- and in case it was not obvious: Yes, it is a good idea to link to the write up repo.

@zachriggle zachriggle added the bug label Dec 15, 2014
@zachriggle zachriggle added this to the 2.2 milestone Dec 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants