Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

int have upperbound limit too low for graphql? #39

Closed
nicolasburtey opened this issue Nov 13, 2020 · 4 comments
Closed

int have upperbound limit too low for graphql? #39

nicolasburtey opened this issue Nov 13, 2020 · 4 comments
Assignees
@krtk6160
Labels
security

Comments

@nicolasburtey
Copy link
Member

"Variable "$value" got invalid value 3616672277; Expected type Int. Int cannot represent non 32-bit signed integer value: 3616672277"

https://console.cloud.google.com/logs/query;pinnedLogId=2020-11-13T16:26:17.438910790Z%2Fryxcfi2amkf239f68;query=resource.type%3D%22k8s_container%22%0Aresource.labels.cluster_name%3D%22testnet-cluster%22%0Aresource.labels.namespace_name%3D%22mainnet%22%0Aresource.labels.container_name%3D%22graphql-server%22%0AjsonPayload.level%3E%3D%2240%22;timeRange=PT3H?project=galoyapp
@nicolasburtey
Copy link
Member Author

if the max value of int is 2,147,483,647, then the issue would arise only when sending 2.1 BTC. This is not really an issue right now but will be if we start opening our wallet to other groups that might have a higher stack of BTC.

@krtk6160
Copy link
Member

if the max value of int is 2,147,483,647, then the issue would arise only when sending 2.1 BTC.

Don't you mean 21.4 BTC?

@nicolasburtey
Copy link
Member Author

yep 21 BTC actually. quite a big number! :) but if this is an attack vector this should still be fixed.

@nicolasburtey nicolasburtey transferred this issue from another repository Mar 16, 2021
@nicolasburtey nicolasburtey mentioned this issue Jul 7, 2021
Closed
@nicolasburtey
Copy link
Member Author

afaik this has been fixed/handled with the new graphql API @samerbuna

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krtk6160 krtk6160

Labels
security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicolasburtey @krtk6160