-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dust beta and Td ellmax #164
Conversation
zonca
commented
Jun 7, 2023
- fix: beta and Td were at lmax 2048
- load new cl spectra and fix last point in spectrum
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
see details about the problem at CMB-S4/s4mapbasedsims#28 |
@giuspugl can you please review the PR? |
minor fixes: load from new path, make extra plot, update images
Test is extremely sensitive, it detects any difference in the last point in the spectrum. Have changed in the generation of the templates, needed to change in test as well.
it is a good sign that the test was failing if using the old templates
19baa19
to
df00930
Compare
I accepted the invitation , thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all looks good! thanks @zonca !
You updated the spectral parameter templates generated with a higher nside. I've a question related to the previous templates, are they gonna be overwritten or replaced with a new pysm version ?
same I did last time with Synchrotron templates. https://portal.nersc.gov/project/cmb/pysm-data/dust_gnilc/ then I will move the original maps inside the |