Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dust beta and Td ellmax #164

Merged
merged 5 commits into from
Jun 12, 2023
Merged

Fix dust beta and Td ellmax #164

merged 5 commits into from
Jun 12, 2023

Conversation

zonca
Copy link
Member

@zonca zonca commented Jun 7, 2023

  • fix: beta and Td were at lmax 2048
  • load new cl spectra and fix last point in spectrum

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@zonca
Copy link
Member Author

zonca commented Jun 7, 2023

see details about the problem at CMB-S4/s4mapbasedsims#28

@zonca zonca self-assigned this Jun 7, 2023
@zonca
Copy link
Member Author

zonca commented Jun 7, 2023

@giuspugl can you please review the PR?

zonca added 5 commits June 6, 2023 21:46
@zonca
fix: beta and Td were at lmax 2048
7b31917 
minor fixes: load from new path, make extra plot, update images
@zonca
load new cl spectra and fix last point in spectrum
b3c34e7
@zonca
update dust templates 2023.06.06
fad8a3d
@zonca
test: update lmax
6371b29 
Test is extremely sensitive, it detects any difference in the last point
in the spectrum. Have changed in the generation of the templates, needed
to change in test as well.
@zonca
test: use new beta and Td templates in test as well
df00930 
it is a good sign that the test was failing if using the old templates
@giuspugl
Copy link
Contributor

giuspugl commented Jun 7, 2023 •
edited
Loading

@giuspugl can you please review the PR?

@zonca can you assign me as a reviewer?

@zonca
Copy link
Member Author

zonca commented Jun 7, 2023

@giuspugl can you please review the PR?

@zonca can you assign me as a reviewer?

doesn't let me. I invited you to the galsci organization

@giuspugl
Copy link
Contributor

giuspugl commented Jun 7, 2023 •
edited
Loading

I accepted the invitation , thanks!

@zonca zonca requested a review from giuspugl June 8, 2023 16:06
giuspugl
giuspugl approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@giuspugl giuspugl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks good! thanks @zonca !
You updated the spectral parameter templates generated with a higher nside. I've a question related to the previous templates, are they gonna be overwritten or replaced with a new pysm version ?

@zonca
Copy link
Member Author

zonca commented Jun 9, 2023

same I did last time with Synchrotron templates.
I add a date to the template name to avoid any caching:

https://portal.nersc.gov/project/cmb/pysm-data/dust_gnilc/

image

then I will move the original maps inside the obsolete folder, so that if anyone tries to run with pysm3.4.0b8, they get a "file not found" error, so that they understand they need to update PySM.

zonca added a commit to zonca/pysm that referenced this pull request Jun 9, 2023
@zonca
suggest to update PySM 3 in case file not found
b9c4b7c 
See galsci#164
@zonca zonca mentioned this pull request Jun 9, 2023
Merged
zonca added a commit to zonca/pysm that referenced this pull request Jun 9, 2023
@zonca
suggest to update PySM 3 in case file not found
32a892c 
See galsci#164
@zonca zonca merged commit 52b055f into galsci:main Jun 12, 2023
3 of 4 checks passed
@zonca zonca deleted the fix_dust_beta_Td_ellmax branch June 12, 2023 19:23
@zonca zonca mentioned this pull request Jun 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giuspugl giuspugl giuspugl approved these changes

Assignees

@zonca zonca

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zonca @giuspugl