More improvements to the management of fonts and colors

In dialogs, parameters, side controls, and inspectors.

msi.gama.application/src/msi/gama/application/workbench/ThemeHelper.java

@@ -21,6 +21,7 @@
 import org.osgi.service.prefs.BackingStoreException;
 import msi.gama.common.preferences.Pref;
 import msi.gaml.types.IType;
+import ummisco.gama.dev.utils.DEBUG;
 
 public class ThemeHelper {
 
@@ -35,6 +36,10 @@ public class ThemeHelper {
 
 	private static final List<IThemeListener> listeners = new ArrayList<>();
 
+	static {
+		DEBUG.ON();
+	}
+
 	public static final Pref<Boolean> CORE_THEME_FOLLOW =
 		create("pref_theme_follow", "Follow OS theme", followOSTheme(), IType.BOOL, false).in(NAME, APPEARANCE)
 			.restartRequired().deactivates("pref_theme_light").onChange(yes -> {
@@ -63,9 +68,14 @@ private static IEclipseContext getContext() {
 	private static Boolean followOSTheme() {
 		final var prefs = getSwtRendererPreferences();
 		final var val = prefs.get(THEME_FOLLOW_PROPERTY, null);
-		if ( val != null )
-			return Boolean.valueOf(val);
-		return Boolean.valueOf(System.getProperty(THEME_FOLLOW_PROPERTY, "true"));
+		Boolean result;
+		if ( val != null ) {
+			result = Boolean.valueOf(val);
+		} else {
+			result = Boolean.valueOf(System.getProperty(THEME_FOLLOW_PROPERTY, "true"));
+		}
+		DEBUG.OUT("Follow OS Theme: " + result);
+		return result;
 	}
 
 	private static void followOSTheme(final Boolean follow) {
@@ -81,6 +91,7 @@ private static void followOSTheme(final Boolean follow) {
 	}
 
 	public static boolean isDark() {
+		// DEBUG.OUT("Asks for isDark(): ", false);
 		String id;
 		final var themeEngine = getContext().get(IThemeEngine.class);
 		if ( themeEngine == null ) {
@@ -95,6 +106,7 @@ public static boolean isDark() {
 			final var theme = themeEngine.getActiveTheme();
 			id = theme == null ? null : theme.getId();
 		}
+		// DEBUG.OUT(" " + (id != null && id.contains("dark")) + " and OS is dark = " + isSystemDarkTheme());
 		return id != null && id.contains("dark");
 	}
 
@@ -146,10 +158,8 @@ private static boolean changeTo(final String id) {
 		if ( themeEngine == null )
 			return true;
 		final var theme = themeEngine.getActiveTheme();
-		if ( theme != null ) {
-			if ( theme.getId().startsWith(id) )
-				return false;
-		}
+		if ( theme != null && theme.getId().startsWith(id) )
+			return false;
 		themeEngine.setTheme(id, true);
 		return true;
 	}

ummisco.gama.ui.experiment/src/ummisco/gama/ui/views/inspectors/AgentInspectView.java

@@ -110,7 +110,6 @@ public Label createLeftLabel(final Composite parent, final String title, final S
 		d.minimumWidth = 70;
 		d.horizontalIndent = isSubParameter ? 30 : 0;
 		label.setLayoutData(d);
-		// label.setFont(GamaFonts.getLabelfont());
 		label.setText(title);
 		label.setToolTipText(tooltip);
 		return label;
@@ -119,8 +118,7 @@ public Label createLeftLabel(final Composite parent, final String title, final S
 	@Override
 	protected Composite createItemContentsFor(final IAgent agent) {
 		final Composite attributes = super.createItemContentsFor(agent);
-		final Label l = createLeftLabel(attributes, "Actions", "", false);
-		// l.setFont(GamaFonts.getExpandfont());
+		createLeftLabel(attributes, "Actions", "", false);
 		final Composite composite = new Composite(attributes, SWT.NONE);
 		composite.setBackground(attributes.getBackground());
 		final GridData data = new GridData(SWT.FILL, SWT.CENTER, true, false);