Skip to content

Commit

Permalink
Two macOS problems solved
Browse files Browse the repository at this point in the history
Solves two problems on macOS (repeatability of the layout and "escape" of some views from it + non-hiding of displays without tabs)
  • Loading branch information
AlexisDrogoul committed May 18, 2022
1 parent 9341e74 commit f2618e4
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 108 deletions.
Expand Up @@ -354,10 +354,10 @@ public void perspectiveActivated(final IWorkbenchPage page, final IPerspectiveDe
view.getOutput().setPaused(true);
}
// Seems necessary in addition to the IPartListener
// WorkbenchHelper.run(() -> {
if (PlatformHelper.isMac() && overlay != null) { overlay.hide(); }
// view.hideCanvas();
// });
WorkbenchHelper.run(() -> {
if (PlatformHelper.isMac() && overlay != null) { overlay.hide(); }
view.hideCanvas();
});
} else {
// Issue #2639
if (PlatformHelper.isMac() && !view.isOpenGL()) {
Expand All @@ -368,11 +368,12 @@ public void perspectiveActivated(final IWorkbenchPage page, final IPerspectiveDe
&& view.getDisplaySurface() != null) {
view.getOutput().setPaused(previousState);
}
// Seems necessary in addition to the IPartListener
// WorkbenchHelper.asyncRun(() -> {
if (PlatformHelper.isMac() && overlay != null) { overlay.display(); }
// view.showCanvas();
// });
// Necessary in addition to the IPartListener as there is no way to distinguish between the wrong
// "hidden" event and the good one when there are no tabs.
WorkbenchHelper.asyncRun(() -> {
if (PlatformHelper.isMac() && overlay != null) { overlay.display(); }
view.showCanvas();
});
}

}
Expand Down

This file was deleted.

0 comments on commit f2618e4

Please sign in to comment.