Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fake pull-request to showcase the checks #174

Closed
wants to merge 7 commits into from
Closed

Fake pull-request to showcase the checks #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2d269fc
Adds deeply nested code for codescene to pickup on
lesquoyb May 16, 2024
ff43c1a
Adds a problem for spotbugs
lesquoyb May 16, 2024
64626de
Breaks a unit test
lesquoyb May 16, 2024
3688376
test PR workflow for spotbugs
lesquoyb May 17, 2024
45203b3
Removes the content that annoys codescene + new test for pr workflow
lesquoyb May 17, 2024
5e0ac1e
test PR workflow for spotbugs (hopefully for the last time)
lesquoyb May 17, 2024
fbe7989
test PR workflow for spotbugs (hopefully for the last time2)
lesquoyb May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions gama.core/src/gama/gaml/multi_criteria/MulticriteriaAnalyzeOperator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,8 @@
return;
}

var spotbug = combinations.size();

Check warning on line 120 in gama.core/src/gama/gaml/multi_criteria/MulticriteriaAnalyzeOperator.java

View workflow job for this annotation

GitHub Actions / SpotBugs

RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT 

Return value of java.util.List.size() ignored, but method has no side effect
Raw output 
This code calls a method and ignores the return value. However, our analysis shows that the method (including its implementations in subclasses if any) does not produce any effect other than return value. Thus, this call can be removed.

We are trying to reduce the false positives as much as possible, but in some cases this warning might be wrong. Common false-positive cases include:

- The method is designed to be overridden and produce a side effect in other projects which are out of the scope of the analysis.

- The method is called to trigger the class loading which may have a side effect.

- The method is called just to get some exception.

If you feel that our assumption is incorrect, you can use a @CheckReturnValue annotation to instruct SpotBugs that ignoring the return value of this method is acceptable.

for (int i = start; i <= end; i++) {
final Set<String> comb = new LinkedHashSet<>(currentSol);
comb.add(criteria.get(i));
Expand Down
2 changes: 1 addition & 1 deletion gama.extension.network/tests/Network Tests/models/network_test_interaction.experiment
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ experiment "Tests for gama.extension.network" type: test skills:[network] {
}

write "network group Spice Girls -- done!";
assert (p1);
assert (p1) and false;
}

}
Loading