Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot edit expand/show more block in container as reusable block #725

Closed
bertiebaggio opened this issue Jul 6, 2020 · 4 comments
Closed
Labels
bug Something isn't working need more info Need additional information

Comments

@bertiebaggio
Copy link

bertiebaggio commented Jul 6, 2020

Describe the bug

Adding a (Stackable) container block that contains a (Stackable) expand/show more block which is then saved as a (Wordpress) reusable block results in an error, and the block is unusable.

To Reproduce
Steps to reproduce the behavior:

  1. Add a Container block
  2. Add an Expand/Show More block to the container
  3. Save the resulting block as a reusable block
  4. Click "edit" on reusable block
  5. See error:

"This block has encountered an error and cannot be previewed" in Gutenberg visual editor.

In console:

TypeError: "t is null"
    value https://example.org/wp-content/plugins/stackable-ultimate-gutenberg-blocks/dist/editor_blocks.js?ver=2.6.1:1
    value https://example.org/wp-content/plugins/stackable-ultimate-gutenberg-blocks/dist/editor_blocks.js?ver=2.6.1:1
    React 12
react-dom.min.js:103:487
TypeError: "this.getActiveTabPanelContainer() is undefined"
    value https://example.org/wp-content/plugins/stackable-ultimate-gutenberg-blocks/dist/editor_blocks.js?ver=2.6.1:1
    value https://example.org/wp-content/plugins/stackable-ultimate-gutenberg-blocks/dist/editor_blocks.js?ver=2.6.1:1
    React 12

In addition, the block cannot be edited either visually or as HTML.

Expected behavior

Block should remain editable after saving as reusable.

Screenshots

stackable-reusable-error

Desktop (please complete the following information):

  • OS: Linux
  • Browser: Firefox
  • Browser Version: 77.0.1 (64-bit)
@bertiebaggio bertiebaggio added the bug Something isn't working label Jul 6, 2020
@bertiebaggio
Copy link
Author

Is there any further information I could provide on this that would help to track down and resolve the issue?

@bfintal
Copy link
Contributor

bfintal commented Sep 3, 2020

@bertiebaggio Can you try it with WordPress 5.5.1? I tried replicating it now and it doesn't produce the error.

If it still does, would you be able to paste here the contents of your console log?

@bfintal bfintal added the need more info Need additional information label Sep 3, 2020
@blankart
Copy link
Contributor

Already resolved in WP 5.5

@bertiebaggio
Copy link
Author

I missed bfintal's comment, but can confirm it is indeed resolved now.

Thanks all 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working need more info Need additional information
Projects
None yet
Development

No branches or pull requests

3 participants