fix: Block max content width #2694
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Pull request artifacts
|
|
Size Change: +10.8 kB (+1%) Total Size: 2.12 MB
ℹ️ View Unchanged
|
bfintal
requested changes
Jun 13, 2023
There was a problem hiding this comment.
Does the bug only happen in nested columns like that's described in the issue? If it so, then maybe the fix should only be applied only in that scenario.
I'm afraid the current fix (adding a style to .stk-inner-blocks > .stk-block) will affect all our blocks and might have unforeseen consequences.
Please refactor to fix only the specific scenario where the issue is seen: so far the issue says that it happens on a columns > inner column > columns nesting. are there other scenarios?
|
I checked if the bug only happens on nested columns and turns out it also happens to other (inner) blocks. Expected output (Editor view): Frontend view (w/o fix): Frontend view (w/ fix): |
bfintal
reviewed
Jun 15, 2023
| hasUnits="px" | ||
| valueCallback={ ( value, getAttribute ) => { | ||
| const blockWidth = getAttribute( 'width' ) | ||
| return blockWidth ? 'inherit' : '' |
There was a problem hiding this comment.
Please use undefined here, I think there's a chance that the style might show up if it's an empty string.
Suggested change
| return blockWidth ? 'inherit' : '' | |
| return blockWidth ? 'inherit' : undefined |
bfintal
requested changes
Jun 15, 2023
bfintal
reviewed
Jun 15, 2023
|
The issue has been fixed but it affected single blocks. Remaining issue:
Screen.Recording.2023-06-16.at.11.35.10.AM.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2502