Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (performance): improvements based on code profiler part 2 #3178

Merged
merged 42 commits into from
May 23, 2024
Merged

fix (performance): improvements based on code profiler part 2 #3178

merged 42 commits into from
May 23, 2024

Conversation

mxkae
Copy link
Contributor

@mxkae mxkae commented May 6, 2024

fixes #3172

bfintal@gmail.com added 30 commits April 25, 2024 18:49
optimized alignment polyfill - do not loop across all elements
2b9d4ca
optimized generate_render_item_from_stackable_posts_block
324ab4d
faster alignment class adding
115e6fd
optimize render_post_items by removing concatenation
050a16a
optimize stackable_register_blocks by not grabbing instance all the time
fe25584
optimized stackable_get_metadata_by_folders by lessening file_exists
20e796e
optimized fonts
a25ee97
optimized unique id by using isset and moving conditions
c64c543
optimized strip_optimized_block_styles
cd9fd1f
optimized load_frontend_scripts_conditionally
d4b5c77
optimize generate_defaults by removing one loop
911f6f6
optimize block registration by moving out get_instance from loop
964e6fd
optimized unique id generation
4636c65
optimized typography_detect_native_blocks by moving conditions around
e7d38ac
optimized jetpack
765929b
optimized adjust_block_styles by changing to isset
811a446
optimized multisite by using only filters when on multisite
f8aeb6c
further optimized strip_optimized_block_styles by moving quick condit…
6de06e8 
…ional checks to the top
optimized form_tag_selector by combining function call
f6ef259
optimized global settings by using isset and removing multiple get_op…
6405da0 
…tion and sprintf
minor optimization by removing in_array
b02ba5e
Optimize lightbox enqueue by using strpos instead
46b0d0d
optimized load_frontend_scripts_conditionally by removing repeated ca…
aea11fa 
…lls to substr
optimized by not loading v2 excerpt when v2 compatibility is disabled
21653e7
prevent checking for unique ids in the backend because it's only used…
034a12f 
… in the frontend
optimized strip_optimized_block_styles by removing the check if the s…
eb58436 
…tring exists first before replacing
optimized load_frontend_scripts_conditionally by changing conditions
59cb79b
optimized load_frontend_scripts_conditionally_v2 by changing to isset
5c94051
Remove the auto-checker for v2 to v3 migration
7e55dc4
optimize gather_google_fonts by only using it in the frontend
44f882c
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024 •
edited

🤖 Pull request artifacts

file commit
pr3178-stackable-3178-merge.zip b6972f7

github-actions bot added a commit that referenced this pull request May 6, 2024
@github-actions
Upload pr3178-stackable-3178-merge.zip (0bd21)
88e75fc 
Pull request: #3178
Commit: 0bd21d1
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

Try this Pull Request in the WordPress playground: https://playground.wordpress.net/?mode=seamless#{"landingPage":"/wp-admin/post-new.php?post_type=page","preferredVersions":{"php":"latest","wp":"latest"},"steps":[{"step":"login","username":"admin","password":"password"},{"step":"installPlugin","pluginZipFile":{"resource":"url","url":"https://raw.githubusercontent.com/gambitph/Stackable/artifacts/pr3178-stackable-3178-merge.zip"}}]}

github-actions bot added a commit that referenced this pull request May 15, 2024
@github-actions
Upload pr3178-stackable-3178-merge.zip (64860)
1043898 
Pull request: #3178
Commit: 64860ff
bfintal
bfintal requested changes May 15, 2024
View reviewed changes
Copy link
Contributor

@bfintal bfintal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments:

  • Please also commit the built file src/stk-block-types.php so the plugin would work even by just doing a checkout

src/blocks.php Outdated
Comment on lines 39 to 40
$block_type = new WP_Block_Type( $metadata['name'], $block_args );
register_block_type( $block_type );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why we can't just register the block right away?

register_block_type( $metadata['name'], $block_args );

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on this documentation , register_block_type accepts a string or an instance of WP_Block_Type for the first argument, if it's a string it will consider it as a path to the block.json and will try to use register_block_type_from_metadata() instead.

@mxkae mxkae changed the base branch from develop to fix/performance-code-profiler May 16, 2024 05:41
Base automatically changed from fix/performance-code-profiler to develop May 23, 2024 11:21
@bfintal bfintal merged commit a525255 into develop May 23, 2024
1 of 6 checks passed
@bfintal bfintal deleted the fix/performance-code-profiler-part-2 branch May 23, 2024 11:24
github-actions bot added a commit that referenced this pull request May 23, 2024
@github-actions
Upload pr3178-stackable-3178-merge.zip (b6972)
778c4ab 
Pull request: #3178
Commit: b6972f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfintal bfintal bfintal requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Performance Optimizations (part 2)
2 participants
@mxkae @bfintal