Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP7 Compatibility #353

Closed
julien731 opened this issue Aug 29, 2016 · 1 comment
Closed

PHP7 Compatibility #353

julien731 opened this issue Aug 29, 2016 · 1 comment

Comments

@julien731
Copy link
Contributor

It seems that the TItan Framework is not compatible with PHP7. As reported here, there are a couple of issues with the framework.

With PHP7 being stable and its adoption rate going up, I believe making sure TF is compatible is an important task. The unit tests should also be ran against PHP7 in Travis CI.
@bfintal
Copy link
Contributor

bfintal commented Aug 31, 2016

Possible fix, this is the same scssphp script used by Jetpack, only namespaced: https://gist.github.com/bfintal/60f303db3c6c3f27002d72ed45947dcb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bfintal @julien731 @ReggieDuran