Update to require C++17.

This changes the build to use C++17. In addition, the autotools macro for checking whether a flag is needed to specify C++17 has been improved to be more generic.
gambitproject · Jan 31, 2024 · dbd201a · dbd201a
1 parent 5875508
commit dbd201a
Show file tree

Hide file tree

Showing 11 changed files with 1,045 additions and 43 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -6,6 +6,8 @@ Checks: |
   -modernize-use-trailing-return-type,
   -modernize-avoid-c-arrays,
   -modernize-pass-by-value,
+  -modernize-use-nodiscard,
+  -modernize-concat-nested-namespaces,
   cppcoreguidelines-pro-type-cstyle-cast,
   cppcoreguidelines-pro-type-member-init,
   cppcoreguidelines-prefer-member-initializer,

diff --git a/ChangeLog b/ChangeLog
@@ -16,6 +16,7 @@
   path-following procedure
 
 ### Changed
+- Gambit now requires a compiler that supports C++17.
 - Functions to compute Nash equilibria now return a NashComputationResult object instead of a bare
   list of profiles (#190)
 - `liap_solve`/`gambit-liap` has been reimplemented to scale payoffs uniformly across games,

diff --git a/Makefile.am b/Makefile.am
@@ -734,8 +734,8 @@ msw-msi:
 	light -ext WixUIExtension gambit.wixobj
 
 clang-tidy:
-	clang-tidy ${top_srcdir}/src/core/*.cc -- --std=c++11 -I ${top_srcdir}/src -I ${top_srcdir}/src/labenski/include -DVERSION="" ${WX_CXXFLAGS}
-	clang-tidy ${top_srcdir}/src/games/*.cc ${top_srcdir}/src/games/*/*.cc -- --std=c++11 -I ${top_srcdir}/src -I ${top_srcdir}/src/labenski/include -DVERSION="" ${WX_CXXFLAGS}
-	clang-tidy ${top_srcdir}/src/solvers/*/*.cc -- --std=c++11 -I ${top_srcdir}/src -I ${top_srcdir}/src/labenski/include -DVERSION="" ${WX_CXXFLAGS}
-	clang-tidy ${top_srcdir}/src/tools/*/*.cc -- --std=c++11 -I ${top_srcdir}/src -I ${top_srcdir}/src/labenski/include -DVERSION="" ${WX_CXXFLAGS}
-	clang-tidy ${top_srcdir}/src/gui/*.cc -- --std=c++11 -I ${top_srcdir}/src -I ${top_srcdir}/src/labenski/include -DVERSION="" ${WX_CXXFLAGS}
+	clang-tidy ${top_srcdir}/src/core/*.cc -- --std=c++17 -I ${top_srcdir}/src -I ${top_srcdir}/src/labenski/include -DVERSION="" ${WX_CXXFLAGS}
+	clang-tidy ${top_srcdir}/src/games/*.cc ${top_srcdir}/src/games/*/*.cc -- --std=c++17 -I ${top_srcdir}/src -I ${top_srcdir}/src/labenski/include -DVERSION="" ${WX_CXXFLAGS}
+	clang-tidy ${top_srcdir}/src/solvers/*/*.cc -- --std=c++17 -I ${top_srcdir}/src -I ${top_srcdir}/src/labenski/include -DVERSION="" ${WX_CXXFLAGS}
+	clang-tidy ${top_srcdir}/src/tools/*/*.cc -- --std=c++17 -I ${top_srcdir}/src -I ${top_srcdir}/src/labenski/include -DVERSION="" ${WX_CXXFLAGS}
+	clang-tidy ${top_srcdir}/src/gui/*.cc -- --std=c++17 -I ${top_srcdir}/src -I ${top_srcdir}/src/labenski/include -DVERSION="" ${WX_CXXFLAGS}