Initialise the MixedBehaviorProfile on creation. Add test to the new … #435
Conversation
tests/test_behav.py
Outdated
| for each player over his actions. | ||
| """ | ||
| profile = game.mixed_behavior_profile(rational=rational_flag, data=data) | ||
| for p in range(len(game.players)): |
There was a problem hiding this comment.
We are trying to avoid using integer indices as it's not very Pythonic. Better would be:
for (player, behavior) in zip(game.players, data):
assert profile[player] == behavior
| @@ -641,3 +645,22 @@ def test_action_value_with_chance_player_action(game: gbt.Game, rational_flag: b | |||
| chance_action = game.players.chance.infosets[0].actions[0] | |||
| with pytest.raises(ValueError): | |||
| game.mixed_behavior_profile(rational=rational_flag).action_value(chance_action) | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize( | |||
There was a problem hiding this comment.
This only tests with data that has the correct "shape". There are no tests to ensure that bad input data is handled appropriate (with an error).
tests/test_behav.py
Outdated
| (games.create_complicated_extensive_game(), False, [[[1/5, 4/5], [3/5, 2/5]], [[1/4, 3/4]]]) | ||
| ] | ||
| ) | ||
| def test_specific_profile(game: gbt.Game, rational_flag: bool, data: float): |
There was a problem hiding this comment.
Type hint for data is not correct.
tests/test_behav.py
Outdated
| [[1/2, 1/2]]) | ||
| ] | ||
| ) | ||
| def test_profile_data_error(game: gbt.Game, rational_flag: bool, data: float): |
There was a problem hiding this comment.
Type hint for data is not correct.
tests/test_behav.py
Outdated
| [["4/9", "5/9"], ["1/3", "2/3"]]) | ||
| ] | ||
| ) | ||
| def test_tree_representation_error(game: gbt.Game, rational_flag: bool, data: float): |
There was a problem hiding this comment.
Type hint for data is not correct.
tests/test_behav.py
Outdated
| number of actions per infoset. | ||
| """ | ||
| with pytest.raises(ValueError): | ||
| game.mixed_behavior_profile(rational=rational_flag,data=data) |
There was a problem hiding this comment.
We prefer a space between function arguments (this is done consistently everywhere else)
VarsosC
force-pushed
the
ENH-353-initialisazion-and-testing-mixed-profiles-on-creation
branch
from
4158424
to
01e0355
Compare
tests/test_behav.py
Outdated
| @pytest.mark.parametrize( | ||
| "game,rational_flag,data", | ||
| [(games.create_mixed_behav_game(), True, | ||
| [[[gbt.Rational("0/1"), gbt.Rational("1/1"), gbt.Rational("0/1")]], |
There was a problem hiding this comment.
Mixed profiles accept anything that can be interpreted as a number as an argument. Therefore you do not need gbt.Rational("0/1") - you can just write "0/1", and so on. But for whole numbers you can just do 0 and 1.
src/pygambit/game.pxi
Outdated
| @@ -768,10 +773,50 @@ class Game: | |||
| if not rational: | |||
There was a problem hiding this comment.
In this case, now that so much code has been added to this branch of the if self.is_tree, it would be much better to reverse the conditional. That is, have a conditional that checks if not self.is_tree first. Then, you do not need an else after that. This can be seen by imitating the implementation of mixed_strategy_profile which is immediately adjacent in the source file.
VarsosC
force-pushed
the
ENH-353-initialisazion-and-testing-mixed-profiles-on-creation
branch
from
01e0355
to
75985ee
Compare
tturocy
force-pushed
the
ENH-353-initialisazion-and-testing-mixed-profiles-on-creation
branch
3 times, most recently
from
39ccd09
to
13a6225
Compare
tturocy
force-pushed
the
ENH-353-initialisazion-and-testing-mixed-profiles-on-creation
branch
from
13a6225
to
2a22cec
Compare
tturocy
deleted the
ENH-353-initialisazion-and-testing-mixed-profiles-on-creation
branch
…test suite that checks the creation of a behavior profile given a distribution.