Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: confusion regarding the 'note taking' example #20

Closed
x3ro opened this issue May 19, 2020 · 1 comment
Closed

Question: confusion regarding the 'note taking' example #20

x3ro opened this issue May 19, 2020 · 1 comment

Comments

@x3ro
Copy link

x3ro commented May 19, 2020

When looking at the note taking example on the Try margin page, the first couple of lines of content currently look like this (SublimeText screenshot so that invisible characters are visible):

Screenshot 2020-05-19 at 15 09 05

I'm somewhat confused about the resulting AST, so here are my questions:

  • Is the single space character after the tabs before "course notes" intentional? It causes the subsequent lines to not be children of the "course notes" line, which seems accidental (?)
  • If I remove a single tab from the Graphic design [...] line it becomes a child of the previous line, though in that case I would expect it not to be, given that both lines now share the same level of indentation? Screenshot 2020-05-19 at 15 14 43

This is potentially related to #5, since it appears to be caused by mixing of tabs and spaces 🤔

@x3ro x3ro changed the title Question: confusion regarding the Question: confusion regarding the 'note taking' example May 19, 2020
gamburg added a commit that referenced this issue Jun 9, 2020
@gamburg
Copy link
Owner

gamburg commented Jun 9, 2020

Good catch on both! The single space was indeed a mistake.

As for the issue with the indentation levels, that incorrect behavior is likely due to the incompleteness of the js parser (there are many things in the js parser that are not to spec).

I'm hoping to dive into #4 (and some open questions around the spec) before worrying too much about getting the example parser up to spec.

@gamburg gamburg closed this as completed Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants