Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for macos #211

Open
Kariaro opened this issue Dec 27, 2022 · 3 comments
Open

Add support for macos #211

Kariaro opened this issue Dec 27, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@Kariaro
Copy link

Kariaro commented Dec 27, 2022

Context
I need to test that external libraries work in Windows, Linux and Macos.

Currently macos is not supported. That's why I'm making this issue

Suggested solution

Copy code from game-ci/unity-builder that handles darwin systems and use it in this repository

Additional details

I'm going to try make a PR for this issue myself and will clone this repository to start testing

@webbertakken
Copy link
Member

Yup! We support this approach and accept contributions.

@Kariaro
Copy link
Author

Kariaro commented Dec 27, 2022

I'm currently looking at the generated docker images for macos but I don't see any here: https://github.com/game-ci/docker/tree/main/images/macos

Should I copy the MacBuilder concept from https://github.com/game-ci/unity-builder/blob/main/src/model/mac-builder.ts and apply it so that if process.platform === 'darwin' I jump to the MacTestRunner instead?

@davidmfinol
Copy link
Member

That's right, there are no docker images for macos, so you would likely need to copy the relevant typescript code from unity-builder.

Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 27, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 28, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 28, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 28, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 28, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 28, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 29, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 29, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 29, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 29, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 29, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 29, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 29, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 29, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 29, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 29, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 29, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 29, 2022
Kariaro added a commit to Kariaro/unity-test-runner that referenced this issue Dec 29, 2022
@davidmfinol davidmfinol added the enhancement New feature or request label Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants