Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Duke Nukem Forever 2001 support #499

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

podrivo
Copy link
Contributor

@podrivo podrivo commented Jan 21, 2024

Adds support for Duke Nukem Forever 2001.
Thanks @cetteup for testing and pointing the protocol! See more at #298

I'm not 100% sure about and could use a confirmation:

release_year: 2022, 
port: 7777, 
port_query_offset: 1

Example response:

node bin/gamedig --type dnf2001 45.89.125.89 --pretty

{
  "name": "The Gravel Pit | EU",
  "map": "DM-64-LivesAgain",
  "password": false,
  "raw": {
    "gamename": "dnf",
    "gamever": 400,
    "minnetver": 400,
    "location": 0,
    "hostname": "The Gravel Pit | EU",
    "hostport": 7777,
    "maptitle": "Untitled",
    "mapname": "DM-64-LivesAgain",
    "gametype": "dnDeathmatchGame",
    "numplayers": 0,
    "maxplayers": 16,
    "gamemode": "openplaying",
    "worldlog": true,
    "listenserver": false,
    "timelimit": 10,
    "fraglimit": 35,
    "minplayers": 0,
    "changelevels": true,
    "adminname": "EduCatOR",
    "teams": {}
  },
  "maxplayers": 16,
  "numplayers": 0,
  "players": [],
  "bots": [],
  "queryPort": 7778,
  "connect": "45.89.125.89:7777",
  "ping": 306
}

@CosminPerRam
Copy link
Member

Thanks.
How did you found that server? When I first tried to add support for it I couldn't find any servers at all.
Querying it works as expected, but I'm saying this in the sense to really know if its a Duke Nukem Forever 2001 server, I had this problem with #446, I was querying a game server on it an apparently another server responded to the query and I caught that just before wanting to merge it.

@podrivo
Copy link
Contributor Author

podrivo commented Jan 21, 2024

It was suggested on the issue by @cetteup. I haven't found any online server as well.
You get "gamename": "dnf" on the response, but not sure if it's enough to say it's the same game.

@CosminPerRam
Copy link
Member

Well, that could be DNF 2011.

@podrivo
Copy link
Contributor Author

podrivo commented Jan 22, 2024

I see. I'll check over their Discord to have confirmation and I'll update here in case they reply.

@podrivo
Copy link
Contributor Author

podrivo commented Jan 29, 2024

Never got a reply from the admin EduCatOR about the server being DNF 2001 or 2011.
I wasn't able to find more information about it, nor other servers to test a bit more.

Copy link
Member

@CosminPerRam CosminPerRam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over #298 they confirmed its DNF 2001 and not 2011, good to merge, just to rebase (:

@podrivo
Copy link
Contributor Author

podrivo commented Jan 29, 2024

Rebased. Good to merge! (:

@CosminPerRam CosminPerRam merged commit 731f553 into gamedig:master Jan 29, 2024
4 of 5 checks passed
@podrivo podrivo deleted the feat/add-dnf2001-support branch January 29, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants