Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animation parse floating-point frame values #186

Closed
BenjaminDRichards opened this issue Feb 23, 2015 · 1 comment
Closed

Animation parse floating-point frame values #186

BenjaminDRichards opened this issue Feb 23, 2015 · 1 comment
Assignees
@BenjaminDRichards
Labels
enhancement
Milestone
v1.3.0

Comments

@BenjaminDRichards
Copy link
Contributor

It would be nice to be able to assign floats to frames. This would allow tweens to control frames without messing up, among other useful abilities.
@BenjaminDRichards BenjaminDRichards self-assigned this Feb 23, 2015
@BenjaminDRichards BenjaminDRichards added this to the v1.3.0 milestone Feb 23, 2015
BenjaminDRichards added a commit that referenced this issue Feb 23, 2015
@BenjaminDRichards
Allow Animation.frameIndex to be set to floating-point values effec…
5c65f42 
…tively

Re issue #186

I've added `Math.floor` to the `frameIndex` setter. This will turn dangerous floats into useful ints.

The additional processing overhead is virtually nil. `frameIndex` is rarely set directly; the guts of the `Animation.update` method use an internal property exclusively.
@BenjaminDRichards
Copy link
Contributor Author

I've added Math.floor to the frameIndex setter. This will turn dangerous floats into useful ints.

The additional processing overhead is virtually nil. frameIndex is rarely set directly; the guts of the Animation.update method use an internal property exclusively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenjaminDRichards BenjaminDRichards

Labels
enhancement
Projects
None yet
Milestone
v1.3.0
Development

No branches or pull requests
1 participant
@BenjaminDRichards