Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stereo Sound Support #52

Open
RobDavenport opened this issue Sep 5, 2022 · 1 comment
Open

Stereo Sound Support #52

RobDavenport opened this issue Sep 5, 2022 · 1 comment
Labels
Audio Related to the Audio or Sound Engine crates. enhancement New feature or request

Comments

@RobDavenport
Copy link
Member

Currently, the sound_engine is single channel mono only. We need to support stereo at least. This might have some relation to the effects issue #51 but I think left/right panning shouldn't be limited to only effects.

This change would affect a few different areas, both in how Oscilloscope displays channels, how sounds are rendered through cpal, and also even how SampleData is stored on the data type. Do we store samples as stereo? Or keep them mono? Theres many ways to do it and currently I don't know what the best approach is, so I'm open to ideas here.

@RobDavenport RobDavenport added enhancement New feature or request Audio Related to the Audio or Sound Engine crates. labels Sep 5, 2022
@RobDavenport RobDavenport added this to the 0.2.0 milestone Sep 21, 2022
@VegaDeftwing
Copy link

If you add in effects that can setero-ize a sample - reverb, ping-pong delay, widening, etc. I think keeping samples themselves mono is a reasonable limitation. Worst case, someone can just load in two samples and pan each hard left and right. Not saying this is a route you should go, just that it's not unreasonable.

@RobDavenport RobDavenport removed this from the 0.2.0 milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Audio Related to the Audio or Sound Engine crates. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants