IDE-4317 give a fixed name for gradle watch launch configuration #3686
Conversation
|
Source Format Successful on liferay-ide folder |
|
@Camork can you open one buildship issue and make some contribution on it? thanks @lily94299570 to find this problem as well |
|
Test failed on LAX linux server on 140e0e7 |
|
Source Format Successful on liferay-ide folder |
|
Test failed on LAX linux server on 68d82cd |
|
Functional Tests build Failed. |
|
Integration Tests Build Failed. |
|
Integration Tests Build Successful. |
|
Functional Tests build Failed. |
| @@ -196,6 +199,33 @@ public static void runGradleTask(IProject project, String[] tasks, String[] argu | |||
| launchConfigurationWC.launch(ILaunchManager.RUN_MODE, monitor); | |||
| } | |||
|
|
|||
| public static void runGradleTask( | |||
There was a problem hiding this comment.
This method is very very close to another method in this same class. can you merge those two methods into one and support both functionality?
| @@ -50,7 +52,7 @@ public void consolesAdded(IConsole[] consoles) { | |||
| if ("GradleConsole".equals(consoleClass.getSimpleName())) { | |||
| String consoleName = console.getName(); | |||
|
|
|||
| if (consoleName.contains("watch")) { | |||
| if (consoleName.startsWith(LiferayGradleWorkspaceProject.WATCH_LAUNCH_CONFIGURATION_NAME)) { | |||
There was a problem hiding this comment.
This constant shouldn't be in this class. The "RemoveOldWatchConsoleListener" class shouldn't know anything about "LiferayGradleWorkspaceProject". So lets refactor this to a constants class.
a long task name will cause error during buildship persisting configuration
Camork
force-pushed
the
IDE-4317
branch
2 times, most recently
from
260dbe9
to
69f641d
Compare
|
Test failed on LAX linux server on 260dbe9 |
|
Source Format Successful on liferay-ide folder |
|
Test failed on LAX linux server on 69f641d |
|
Source Format Successful on liferay-ide folder |
|
Functional Tests build Failed. |
|
Test failed on LAX linux server on 734d9d0 |
|
Pull request submitted to #3692. See changes here. |
Sent from
|
Integration Tests Build Successful. |
|
Functional Tests build Failed. |
a long task name will cause error during buildship persisting configuration