Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skins stop working on server restart #4

Closed
ghost opened this issue Apr 28, 2016 · 38 comments
Closed

Skins stop working on server restart #4

ghost opened this issue Apr 28, 2016 · 38 comments

Comments

@ghost
Copy link

ghost commented Apr 28, 2016

When I first added the plugin, everything worked perfectly, skins loaded with no problems. Though, now that I restarted the server, skins don't load anymore. I run an offline Spigot 1.9 server.

I have noticed that if I stop the server, delete the "ChangeSkin.db" file, and start it again, the plugin works just as well as the first time I ran it. But I don't want to delete that file every time I have to restart the server, as it gets annoying.

I use the plugin version 0.8, because version 0.9 throws an error.
v 0.9 error: http://hastebin.com/eyatodemaj.sm

@games647
Copy link
Owner

games647 commented Apr 29, 2016

But I don't want to delete that file every time I have to restart the server, as it gets annoying.

Of course.

The problem is that. Version 0.9 expects a Spigot servers, but you are running craftbukkit.

Related to 461eb7d

@games647
Copy link
Owner

I guess the changes I made will fix it. I'll upload it today after some tests.

@ghost
Copy link
Author

ghost commented Apr 29, 2016

Oh wow, sorry about that, I thought I was using spigot, but a closer look at the logs show I had been using CraftBukkit all along. I'll switch over to Spigot right away

So I'm now running Spigot and ChangeSkin v0.9, but I still have the same issue.

@ghost ghost closed this as completed Apr 29, 2016
@ghost ghost reopened this Apr 29, 2016
@games647
Copy link
Owner

games647 commented Apr 29, 2016

Do you still have this issue?

@ghost
Copy link
Author

ghost commented Apr 29, 2016

Yeah, and it also seems to happen when I use a MySQL database instead of the SQLite storage.

@games647
Copy link
Owner

Any errors?

@ghost
Copy link
Author

ghost commented Apr 29, 2016

None

@games647
Copy link
Owner

games647 commented Apr 30, 2016

Found the issue. I'll fix it.

EDIT: the column type timestamp in mySQL ignores milliseconds.

@games647
Copy link
Owner

Sorry I didn't noticed that earlier.

@ghost
Copy link
Author

ghost commented Apr 30, 2016

No worries! Can you link me to the fixed version?

@games647
Copy link
Owner

@ghost
Copy link
Author

ghost commented May 1, 2016

Thanks for the link, although it still doesn't work

@games647
Copy link
Owner

games647 commented May 1, 2016

Oh, I forgot to say that I changed the table setup. You should regenerate the table.

@ghost
Copy link
Author

ghost commented May 1, 2016

I tested it this morning, and it still isn't working. I tried the plugin with SQLite and MySQL, both have the same problem.

@games647
Copy link
Owner

games647 commented May 1, 2016

Oh, I'm really sorry. I created this issue by fixing #5. I fixed it now. I'll upload a new version right away.

@ghost
Copy link
Author

ghost commented May 1, 2016

No worries! Just send me the link and I'll try it out!

@games647
Copy link
Owner

games647 commented May 1, 2016

Update is uploaded.

https://www.spigotmc.org/resources/changeskin.21469/update?update=87369

I hope it works now for you.

@ghost
Copy link
Author

ghost commented May 1, 2016

It still doesn't work, with both MySQL or SQLite

@games647
Copy link
Owner

games647 commented May 1, 2016

Do you regenerated the table?

@ghost
Copy link
Author

ghost commented May 1, 2016

Yeah, I deleted them before testing

@games647
Copy link
Owner

games647 commented May 1, 2016

It works now absolutely fine for me. Does the skin apply if you invoke /setskin ?

@ghost
Copy link
Author

ghost commented May 1, 2016

I can change to any skin that is not already in the database, but not those that have been downloaded already

@games647
Copy link
Owner

games647 commented May 1, 2016

I should have fixed this in 0.9.3. Do you have this effect only after server restarts or do you just receive no new skin if you invoke that command?

@ghost
Copy link
Author

ghost commented May 1, 2016

Only after server restarts. Like, if I remove the tables in the database, everything works, until I restart the server.

@games647
Copy link
Owner

games647 commented May 1, 2016

Could I get the startup log?

@ghost
Copy link
Author

ghost commented May 1, 2016

@games647 games647 reopened this May 1, 2016
@games647
Copy link
Owner

games647 commented May 1, 2016

Do you receive an empty skin or keep your old one?

Sorry for all the questions. I thought I fixed it in 0.9.3. After that update I cannot longer reproduce this issue.

@ghost
Copy link
Author

ghost commented May 1, 2016

Well I don't really know if it's an empty skin. It's the default Steve skin, and not my own.

No worries, I'll help however I can!

@games647
Copy link
Owner

games647 commented May 1, 2016

Does it happen only to you? Which skin do you tried?

@ghost
Copy link
Author

ghost commented May 1, 2016

I'm not sure if it's only with me, I will check a little later with a friend, though I think it's everyone. I try my own skin, and other random skins. Like I said, if I delete the tables before restarting the server, any skin works

@ghost
Copy link
Author

ghost commented May 1, 2016

So it only seems to be happening to me, but I don't know what could be causing it. I have a valid Minecraft account and everything with a skin.

@games647
Copy link
Owner

games647 commented May 2, 2016

Found it. You use a different skin model. Your skin has slim arms instead of square ones.

@ghost
Copy link
Author

ghost commented May 2, 2016

So is there a way to fix that? Should I use the Steve template, or the Alex template?

@games647
Copy link
Owner

games647 commented May 2, 2016

Yes I'll fix that.

@ghost
Copy link
Author

ghost commented May 2, 2016

Ohh, I thought I needed to change my skin model or something. But let me know when it's fixed, I'll try it out!

@games647
Copy link
Owner

games647 commented May 2, 2016

Do you changed your skin?

@ghost
Copy link
Author

ghost commented May 2, 2016

I tried using a random skin and everything works fine, so I'm really not sure what's wrong with my skin

@ghost
Copy link
Author

ghost commented May 2, 2016

Thanks a lot for all the fixes, everything is now working great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant