Fitting changes and 4FGL GTI-bin analysis. #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mireianievas
commented
Aug 4, 2020
mireianievas
commented
- Tune a bit the fitting method (I'm still not completely convinced by its robustness, ideas are welcome)
- Update the 4FGL catalog revision to 22.
- Some changes for DESY's cluster.
- Discovered feature: if you pass the 4FGL to the ScienceTools as a filter, then it takes its GTI intervals and you basically get a 4FGL-like analysis. This could be in principle done also with the old GTI-bin analysis then consolidate, but with that method it takes ages and it is very analysis crash-prone. I provide a first implementation to allow to use this.
added 5 commits
April 13, 2020 11:58
…picked up. The absolute path was missing. Do not crash in the case that the decorrelation energy cannot be set (in case it is for some reason out of the range of valid energies). Generate output XML to be used by the ModelMap generator (needed for the residual and subtracted map production) Minor typos corrected
- Try to write the fits files into temporary output files and then move (might avoid corrupted or incomplete output files in case the job crashes or gets killed silently in a cluster). - Small fixes in the subtract / residual map generation. - Changes in the XML model to lower the minimum normalization value to 0. The default value was introducing artifacts in the analysis of very dim sources, causing an overestimation in the fluxes and bad residuals.
… you pass a LAT catalog (tested with the 4FGL) as the GTI file, then it re-uses the GTI bins defined in such catalog. One can use that to mimmick the 4FGL analysis with their time bins. With this commit I provide a temptative implementation to allow to use such files. Also includes minor fixes
… interval and then consolidate into a new event file), if it is a .fits file, use the new analysis (pass directly the catalog/fits file to the science tools.
Conflicts: enrico/RunGTlike.py enrico/fitmaker.py enrico/gtfunction.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.